Skip to content

feat(devtools): check if signal graph is supported - #61915

Closed
milomg wants to merge 1 commit into
angular:mainfrom
milomg:signal-graph-5
Closed

feat(devtools): check if signal graph is supported#61915
milomg wants to merge 1 commit into
angular:mainfrom
milomg:signal-graph-5

Conversation

@milomg

@milomg milomg commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

add a new devtools field in SupportedApis to check if the getSignalGraphApi exists

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

See #60478 for a more complete demo

By setting this API to unsupported, we can also hide the UI until it is more complete

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: devtools labels Jun 6, 2025
@ngbot ngbot Bot added this to the Backlog milestone Jun 6, 2025
@milomg
milomg force-pushed the signal-graph-5 branch 2 times, most recently from fad4d1e to 43db63d Compare June 6, 2025 03:01
hawkgs
hawkgs reviewed Jun 6, 2025
View reviewed changes
Comment thread devtools/projects/ng-devtools-backend/src/lib/ng-debug-api/ng-debug-api.ts
hawkgs
hawkgs reviewed Jun 9, 2025
View reviewed changes
Comment thread devtools/projects/ng-devtools-backend/src/lib/ng-debug-api/ng-debug-api.spec.ts
@milomg
refactor(devtools): check if signal graph is supported
0cc2ca8 
add a new devtools field in SupportedApis to check if the
getSignalGraphApi exists
@hawkgs hawkgs added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 9, 2025
@AndrewKushnir

AndrewKushnir commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit fd2fca8.

The changes were merged into the following branches: main

@milomg
milomg deleted the signal-graph-5 branch June 11, 2025 21:38
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 18, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hawkgs hawkgs hawkgs approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: devtools detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@milomg @AndrewKushnir @hawkgs