Skip to content

feat(core): Add destroyed property on DestroyRef #61849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atscott wants to merge 1 commit into from
Closed

feat(core): Add destroyed property on DestroyRef #61849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions goldens/public-api/core/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,7 @@ export function destroyPlatform(): void;

// @public
export abstract class DestroyRef {
abstract get destroyed(): boolean;
abstract onDestroy(callback: () => void): () => void;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/core/rxjs-interop/src/take_until_destroyed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ export function takeUntilDestroyed<T>(destroyRef?: DestroyRef): MonoTypeOperator
}

const destroyed$ = new Observable<void>((subscriber) => {
if ((destroyRef as unknown as {destroyed: boolean}).destroyed) {
if (destroyRef.destroyed) {
subscriber.next();
return;
}
const unregisterFn = destroyRef!.onDestroy(subscriber.next.bind(subscriber));
const unregisterFn = destroyRef.onDestroy(subscriber.next.bind(subscriber));
return unregisterFn;
});

Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/linker/destroy_ref.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ export abstract class DestroyRef {
*/
abstract onDestroy(callback: () => void): () => void;

/** @internal */
/**
* Indicates whether the instance has already been destroyed and whether its `onDestroy` callbacks have executed.
*/
abstract get destroyed(): boolean;

/**
Expand Down