Conversation
angular-robot
Bot
added
detected: feature
devversion
requested review from
AleksanderBodurri
and removed request for
devversion
May 21, 2025 15:42
AleksanderBodurri
approved these changes
Jun 1, 2025
JeanMeche
approved these changes
Jun 1, 2025
JeanMeche
added
action: merge
add a new devtools backend api getSignalGraph that emits a latestSignalGraph to the devtools frontend
Contributor
|
@milomg Can you please rebase this PR agains the patch branch? |
kirjs
added
action: cleanup
JeanMeche
added
target: minor
JeanMeche
removed their request for review
June 3, 2025 12:30
Contributor
Author
|
@kirjs I'm assuming that now the PR is targeting minor that being on top of main is ok? If not, I'm happy to rebase |
Contributor
|
This PR was merged into the repository by commit 4fa1dca. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
This allows the devtools frontend code to query the framework getSignalGraph API, which will enable us to visualize the signals graph in devtools
Related: #60772 (currently we'll get an error if we call getSignalGraph on a componentless injector)
Does this PR introduce a breaking change?
Other information