Conversation
angular-robot
Bot
added
detected: feature
milomg
changed the title
milomg
marked this pull request as ready for review
May 20, 2025 21:00
Member
|
Can the commit message maybe include why we're patching the lib ? |
Contributor
Author
|
@JeanMeche Is this what you were thinking of?
|
Member
|
🤦♂️ My bad, yes. |
JeanMeche
approved these changes
May 21, 2025
JeanMeche
added
action: merge
add dagre-d3-es for use by the signals graph pane. Additionally, add a patch so that html labels display correctly within d3-zoom
JeanMeche
added
target: minor
Member
|
The PR doesn't merge properly into main, we'll target |
JeanMeche
added
target: rc
JeanMeche
approved these changes
May 21, 2025
thePunderWoman
changed the title
Contributor
|
This PR was merged into the repository by commit 33715b0. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
I've installed dagre-d3-es as a new package for use in devtools.
This is the most popular fork of dagre, which still doesn't work with esm (and therefore is harder to integrate into our build pipeline). Dagre will allow us to layout the signals visualization in a compact graph
See #60478 for a more complete demo
Does this PR introduce a breaking change?
Other information