Skip to content

fix(compiler-cli): avoid fatal diagnostics for invalid module schemas #61220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clydin wants to merge 1 commit into from
Closed

fix(compiler-cli): avoid fatal diagnostics for invalid module schemas #61220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions packages/compiler-cli/src/ngtsc/annotations/ng_module/src/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,26 @@ export class NgModuleDecoratorHandler
}
}

const schemas =
this.compilationMode !== CompilationMode.LOCAL && ngModule.has('schemas')
? extractSchemas(ngModule.get('schemas')!, this.evaluator, 'NgModule')
: [];
let schemas: SchemaMetadata[] | undefined;
try {
schemas =
this.compilationMode !== CompilationMode.LOCAL && ngModule.has('schemas')
? extractSchemas(ngModule.get('schemas')!, this.evaluator, 'NgModule')
: [];
} catch (e) {
if (e instanceof FatalDiagnosticError) {
diagnostics.push(e.toDiagnostic());

// Use an empty schema array if schema extract fails.
// A build will still fail in this case. However, for the language service,
// this allows the module to exist in the compiler registry and prevents
// cascading diagnostics within an IDE due to "missing" components. The
// originating schema related errors will still be reported in the IDE.
schemas = [];
} else {
throw e;
}
}

let id: Expression | null = null;
if (ngModule.has('id')) {
Expand Down