Conversation
hawkgs
commented
May 8, 2025
Member
Author
There was a problem hiding this comment.
It seems that a lot of the CSS in this file is no longer used/relevant.
hawkgs
force-pushed
the
devtools/responsive-splitter
branch
2 times, most recently
from
May 8, 2025 11:51
101bbc2 to
cd59391
Compare
JeanMeche
reviewed
May 8, 2025
hawkgs
force-pushed
the
devtools/responsive-splitter
branch
from
May 8, 2025 12:05
e95eb14 to
98c821f
Compare
hawkgs
force-pushed
the
devtools/responsive-splitter
branch
2 times, most recently
from
May 9, 2025 15:13
468f03d to
8c4f148
Compare
Member
Author
|
@AleksanderBodurri, I went with the flat config structure. I've added a more descriptive TSDoc comments that should, hopefully, clarify which direction is activated by the ratio and under which conditions. |
hawkgs
force-pushed
the
devtools/responsive-splitter
branch
from
May 12, 2025 07:55
8c4f148 to
fa85b1c
Compare
AleksanderBodurri
approved these changes
May 12, 2025
The `ResponsiveSplitDirective` adds responsive behavior to the `as-split` component by a provided width to height ratio.
hawkgs
force-pushed
the
devtools/responsive-splitter
branch
from
May 19, 2025 14:52
fa85b1c to
2761487
Compare
hawkgs
added
action: merge
thePunderWoman
added
action: cleanup
Run window:resize outside of Angular.
hawkgs
force-pushed
the
devtools/responsive-splitter
branch
from
May 19, 2025 16:33
2761487 to
9f42d58
Compare
Member
Author
|
Tests are now passing successfully. |
hawkgs
added
action: merge
Contributor
|
This PR was merged into the repository by commit f5c67f1. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
The
ResponsiveSplitDirectiveadds responsive behavior to theas-splitcomponent by a provided width to height ratio. It's now employed by the Injector Tree tab.Needed for #60478 as well.
cc @dgp1130
Does this PR introduce a breaking change?