Initial PR for migration to rules_js - #61087
Closed
josephperrott wants to merge 8 commits into
Closed
josephperrott wants to merge 8 commits into
josephperrott wants to merge 8 commits into
Conversation
josephperrott
added
action: merge
josephperrott
added
target: rc
Add a configuration file to prevent autogenerated files from being formatted.
This is necessary for an incremental migration to `rules_js` which requires Bazel v6. Bazel v6 removed the managed directories feature, which means we no longer can rely on symlinked node modules as the Bazel repository; but rather need to duplicate dependencies. This is okay/acceptable to enable the incremental migration.
Sets up `rules_js` and links dependencies into the bazel-bin.
This commit sets up `rules_ts`, providing the `ts_library` equivalent for the `rules_js` migration.
The `ts_project` interop rule that we've built was also used in the Angular CLI migration, and it allows us to mix `ts_project` and `ts_library` targets; enabling an incremental migration. Additionally set up the `ng_project` to replace `ng_module`.
This will automatically result in Renovate updating the Aspect lock files.
This will result in the release tool automatically updating the Aspect lock files when necessary.
josephperrott
marked this pull request as ready for review
May 2, 2025 14:04
JeanMeche
added
the
merge: caretaker note
Member
|
Caretaker note: The linting error is about the licenses. They're good to go. |
Contributor
|
This PR was merged into the repository by commit 1e79d47. The changes were merged into the following branches: main, 20.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
Add a configuration file to prevent autogenerated files from being formatted. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This is necessary for an incremental migration to `rules_js` which requires Bazel v6. Bazel v6 removed the managed directories feature, which means we no longer can rely on symlinked node modules as the Bazel repository; but rather need to duplicate dependencies. This is okay/acceptable to enable the incremental migration. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
Sets up `rules_js` and links dependencies into the bazel-bin. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This commit sets up `rules_ts`, providing the `ts_library` equivalent for the `rules_js` migration. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
The `ts_project` interop rule that we've built was also used in the Angular CLI migration, and it allows us to mix `ts_project` and `ts_library` targets; enabling an incremental migration. Additionally set up the `ng_project` to replace `ng_module`. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This will automatically result in Renovate updating the Aspect lock files. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This will result in the release tool automatically updating the Aspect lock files when necessary. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This is necessary for an incremental migration to `rules_js` which requires Bazel v6. Bazel v6 removed the managed directories feature, which means we no longer can rely on symlinked node modules as the Bazel repository; but rather need to duplicate dependencies. This is okay/acceptable to enable the incremental migration. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
Sets up `rules_js` and links dependencies into the bazel-bin. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This commit sets up `rules_ts`, providing the `ts_library` equivalent for the `rules_js` migration. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
The `ts_project` interop rule that we've built was also used in the Angular CLI migration, and it allows us to mix `ts_project` and `ts_library` targets; enabling an incremental migration. Additionally set up the `ng_project` to replace `ng_module`. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This will automatically result in Renovate updating the Aspect lock files. PR Close #61087
AndrewKushnir
pushed a commit
that referenced
this pull request
May 2, 2025
This will result in the release tool automatically updating the Aspect lock files when necessary. PR Close #61087
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.