Skip to content

fix(common): issue a warning instead of an error when NgOptimizedImage exceeds the preload limit - #60879

Closed
alan-agius4 wants to merge 1 commit into
angular:mainfrom
alan-agius4:optimize-image
Closed

alan-agius4 wants to merge 1 commit into
angular:mainfrom
alan-agius4:optimize-image

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

This should not be treated as a hard error, as it doesn’t break the application but merely degrades performance.

Closes #60871

@pullapprove
pullapprove Bot requested a review from thePunderWoman April 16, 2025 07:10
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Apr 16, 2025
@angular-robot angular-robot Bot added the area: common Issues related to APIs in the @angular/common package label Apr 16, 2025
@ngbot ngbot Bot added this to the Backlog milestone Apr 16, 2025
…ge` exceeds the preload limit

This should not be treated as a hard error, as it doesn’t break the application but merely degrades performance.

Closes angular#60871
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 16, 2025

@thePunderWoman thePunderWoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 16, 2025
@JeanMeche JeanMeche added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Apr 16, 2025
@JeanMeche

Copy link
Copy Markdown
Member

This doesn't merge cleanly on the patch branch, we'll need a separate PR.

@alan-agius4

Copy link
Copy Markdown
Contributor Author

Cherry-pick version: #60883

@kirjs

kirjs commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit cbbea70.

The changes were merged into the following branches: main

@kirjs kirjs closed this in cbbea70 Apr 16, 2025
@alan-agius4
alan-agius4 deleted the optimize-image branch April 16, 2025 16:03
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSR outputs <!--container--> instead of HTML as per template syntax

4 participants