Conversation
crisbeto
added
action: review
angular-robot
Bot
added
area: compiler
angular-robot
Bot
added
area: compiler
crisbeto
marked this pull request as ready for review
November 30, 2024 10:12
angular-robot
Bot
added
area: compiler
alxhub
reviewed
Dec 5, 2024
Member
There was a problem hiding this comment.
Does this work for you? I've had some trouble in g3 with export let variables.
Member
Author
There was a problem hiding this comment.
It worked fine during a presubmit, but I haven't tried TGPing it. I'll make the constant private and add a function to read it, just to be safe.
Tweaks the `getProjectRelativePath` function so it's not as dependent on the TypeScript AST.
Captures the template path in the component's metadata so it can be used later on.
Adds the implementation of the `ɵɵattachSourceLocations` instruction that will add the `data-ng-source-location` attribute to nodes to indicate where they were defined.
Adds the logic that will generate the `ɵɵattachSourceLocations` instruction. Fixes angular#42530.
angular-robot
Bot
removed
the
area: compiler
angular-robot
Bot
added
area: compiler
alxhub
approved these changes
Dec 5, 2024
crisbeto
added
action: merge
JoostK
approved these changes
Dec 5, 2024
Member
|
This PR was merged into the repository by commit 4559e12. The changes were merged into the following branches: main |
alxhub
pushed a commit
that referenced
this pull request
Dec 6, 2024
Captures the template path in the component's metadata so it can be used later on. PR Close #58982
alxhub
pushed a commit
that referenced
this pull request
Dec 6, 2024
) Adds the implementation of the `ɵɵattachSourceLocations` instruction that will add the `data-ng-source-location` attribute to nodes to indicate where they were defined. PR Close #58982
alxhub
pushed a commit
that referenced
this pull request
Dec 6, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…8982) Tweaks the `getProjectRelativePath` function so it's not as dependent on the TypeScript AST. PR Close angular#58982
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Captures the template path in the component's metadata so it can be used later on. PR Close angular#58982
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ular#58982) Adds the implementation of the `ɵɵattachSourceLocations` instruction that will add the `data-ng-source-location` attribute to nodes to indicate where they were defined. PR Close angular#58982
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
Adds the logic that will generate the `ɵɵattachSourceLocations` instruction. Fixes angular#42530. PR Close angular#58982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some logic to include the original template location on each DOM node. Currently there's no way to enable this, apart from making a local change to the compiler. The main usage is aimed at internal tools, but we may consider exposing this in dev mode in the future.
Fixes #42530.