refactor(docs-infra): migrate adev to signal-based inputs - #58453
Closed
pkozlowski-opensource wants to merge 1 commit into
Closed
pkozlowski-opensource wants to merge 1 commit into
pkozlowski-opensource wants to merge 1 commit into
Conversation
This change is the result of running the automated input migration on adev (with the safe flags).
angular-robot
Bot
added
the
area: docs-infra
Contributor
|
@pkozlowski-opensource FYI it is not updated the relevant html files. |
Member
Author
|
@sheikalthaf yep. Opened #58455 to track this |
Contributor
|
@pkozlowski-opensource also the migration is skipped the dynaimcally created component inputs usage
|
JeanMeche
approved these changes
Oct 31, 2024
JeanMeche
reviewed
Oct 31, 2024
| @Input() item?: SearchResult; | ||
| @Input() disabled = false; | ||
| readonly item = input<SearchResult>(); | ||
| readonly disabled = input(false); |
Member
There was a problem hiding this comment.
This is actually breaking because disabled is overriding the definition of Highlightable
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is the result of running the automated input migration on adev (with the safe flags).