Skip to content

feat(compiler): add support for the typeof keyword in template expressions - #58183

Closed
JeanMeche wants to merge 4 commits into
angular:mainfrom
JeanMeche:feat/typeof
Closed

feat(compiler): add support for the typeof keyword in template expressions#58183
JeanMeche wants to merge 4 commits into
angular:mainfrom
JeanMeche:feat/typeof

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Oct 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This commit adds the support for typeof in template expressions like interpolations, bindings, control flow blocks etc.

@pullapprove
pullapprove Bot requested a review from JoostK October 13, 2024 23:54
@JeanMeche
JeanMeche requested review from alxhub and removed request for JoostK October 13, 2024 23:54
@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 13, 2024
@ngbot ngbot Bot modified the milestone: Backlog Oct 13, 2024
@JeanMeche
JeanMeche requested a review from JoostK October 13, 2024 23:54
@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 14, 2024
JeanMeche
JeanMeche commented Oct 14, 2024
View reviewed changes
Comment thread packages/compiler/src/expression_parser/lexer.ts Outdated

@JeanMeche JeanMeche Oct 14, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function was unused.

@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 14, 2024
@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 14, 2024
@ngbot ngbot Bot modified the milestone: Backlog Oct 14, 2024
@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 14, 2024
crisbeto
crisbeto reviewed Oct 14, 2024
View reviewed changes
Comment thread packages/compiler/src/expression_parser/ast.ts Outdated
Comment thread packages/compiler/test/expression_parser/parser_spec.ts Outdated
Comment thread packages/compiler/test/expression_parser/utils/unparser.ts Outdated
Comment thread packages/compiler/src/expression_parser/lexer.ts Outdated

@crisbeto crisbeto Oct 14, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be triple equals.

@JeanMeche JeanMeche Oct 14, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the method above use ===, should we update them too ?

@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 14, 2024
@kuncevic

kuncevic commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

This is how random discussions in the Angular team Slack turn into PRs like that 🔥

@JeanMeche
feat(compiler): add support for the typeof keyword in template expr…
d2f3f00 
…essions.

This commit adds the support for `typeof` in template expressions like interpolation, bindings, control flow blocks etc.
@JeanMeche
fixup! feat(compiler): add support for the typeof keyword in templa…
992769f 
…te expressions.
@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 15, 2024
@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 15, 2024
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Oct 16, 2024
@JeanMeche
JeanMeche removed the request for review from alxhub October 16, 2024 01:28
@JeanMeche JeanMeche added the target: major This PR is targeted for the next major release label Oct 16, 2024
@devversion devversion added the action: presubmit The PR is in need of a google3 presubmit label Oct 16, 2024
@devversion

devversion commented Oct 16, 2024

Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 0c9d721.

The changes were merged into the following branches: main

devversion added a commit to devversion/angular that referenced this pull request Oct 16, 2024
@devversion
Revert "feat(compiler): add support for the typeof keyword in templ…
2c022d8 
…ate expressions. (angular#58183)"

This reverts commit 0c9d721.
This breaks CI jobs in `main`, and sync into google3. PR was green and
presubmit too; so I'm suspecting some rebase conflicts with other
changes being merged at the same time.
@JeanMeche JeanMeche reopened this Oct 16, 2024
@angular-robot angular-robot Bot added area: compiler Issues related to `ngc`, Angular's template compiler and removed area: compiler Issues related to `ngc`, Angular's template compiler labels Oct 16, 2024
@JeanMeche JeanMeche closed this Oct 16, 2024
@JeanMeche
JeanMeche deleted the feat/typeof branch October 16, 2024 12:44
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 16, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 16, 2024
aceArt-GmbH pushed a commit to aceArt-GmbH/angular that referenced this pull request Jan 3, 2025
@JeanMeche lukas
feat(compiler): add support for the typeof keyword in template expr…
4aa8050 
…essions. (angular#58183)

This commit adds the support for `typeof` in template expressions like interpolation, bindings, control flow blocks etc.

PR Close angular#58183
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK approved these changes
@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: compiler Issues related to `ngc`, Angular's template compiler detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

6 participants

@JeanMeche @kuncevic @alxhub @devversion @JoostK @crisbeto