Conversation
angular-robot
Bot
added
area: build & ci
angular-robot
Bot
added
the
area: language-service
pullapprove
Bot
requested review from
AndrewKushnir,
alxhub,
crisbeto,
jelbourn,
josephperrott and
pkozlowski-opensource
October 11, 2024 10:37
JeanMeche
changed the title
standalone: false
JeanMeche
marked this pull request as draft
October 11, 2024 10:38
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 11, 2024 12:30
ae2644c to
8ad32a9
Compare
angular-robot
Bot
added
area: core
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 11, 2024 12:35
8ad32a9 to
f4e77a4
Compare
angular-robot
Bot
added
area: core
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 11, 2024 12:44
f4e77a4 to
a20849e
Compare
angular-robot
Bot
added
area: core
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 11, 2024 12:55
a20849e to
596a31f
Compare
angular-robot
Bot
added
area: core
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 12, 2024 12:31
fdcb239 to
3c4512f
Compare
angular-robot
Bot
added
area: core
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 12, 2024 13:26
3c4512f to
935991a
Compare
angular-robot
Bot
added
area: core
…ag` schematic. All components, directives and pipes will now use standalone as default. Non-standalone decorators have now `standalone: false`.
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .
All components, directives and pipes will now use standalone as default. Non-standalone decorators have now .
… default This commit is part of the migration to standalone by default.
…e by default This commit is part of the migration to standalone by default.
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 12, 2024 14:27
935991a to
179d8ae
Compare
angular-robot
Bot
added
area: core
JeanMeche
marked this pull request as ready for review
October 12, 2024 21:41
This commit is part of the update to standalone by default
JeanMeche
force-pushed
the
feat/standalone-explicit-false
branch
from
October 12, 2024 21:43
179d8ae to
73db6f2
Compare
angular-robot
Bot
added
area: core
Member
|
@JeanMeche @jelbourn is this really ready to merge? I see global approval, but many pending reviewers. Please remove those if ready (caretaker only merges PRs that are fully green w/ merge ready— OR if there is a caretaker note for pending/failing checks) |
Member
|
This PR was merged into the repository by commit c42759b. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st step to migrate the repo to enable standalone by default: Prepare the codebase to recieve the change by setting
standalone: falseon NgModule declared components.