Skip to content

refactor(core): Improve explicit-standalone-flag migration. - #57717

Closed
JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:fix/schematic-standalone
Closed

JeanMeche wants to merge 1 commit into
angular:mainfrom
JeanMeche:fix/schematic-standalone

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Sep 7, 2024 •

Copy link
Copy Markdown
Member

Keep standalone:true

This commit also adds the support of handling standalone proparties assigned by variables (or via shorthand assignments).

@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Sep 7, 2024
@ngbot ngbot Bot added this to the Backlog milestone Sep 7, 2024
@JeanMeche
JeanMeche force-pushed the fix/schematic-standalone branch 3 times, most recently from ecd9a5e to a23f69a Compare September 8, 2024 23:04
@JeanMeche
JeanMeche marked this pull request as ready for review September 9, 2024 01:28
@pullapprove
pullapprove Bot requested a review from alxhub September 9, 2024 01:28
Comment thread packages/core/schematics/test/explicit_standalone_flag_spec.ts Outdated
This commit also adds the support of handling standalone proparties assigned by variables (or via shorthand assignments).
@JeanMeche
JeanMeche force-pushed the fix/schematic-standalone branch from a23f69a to 5d80ab3 Compare September 11, 2024 20:47
@angular-robot angular-robot Bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Sep 11, 2024
@JeanMeche

Copy link
Copy Markdown
Member Author

For compatibility reasons, the migration will skip removing standalone: true, we'll re-enable it later (before the release of course).

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release action: presubmit The PR is in need of a google3 presubmit labels Sep 13, 2024
@AndrewKushnir

Copy link
Copy Markdown
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Sep 13, 2024
@AndrewKushnir
AndrewKushnir removed the request for review from alxhub September 13, 2024 15:53
@pkozlowski-opensource

Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 41c212d.

The changes were merged into the following branches: main

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: migrations Issues related to `ng update`/`ng generate` migrations target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants