Skip to content

refactor(core): introduce debugName optional arg to ReactiveNode - #57710

Closed
AleksanderBodurri wants to merge 1 commit into
angular:mainfrom
AleksanderBodurri:signal-function-debug-names-primitive
Closed

refactor(core): introduce debugName optional arg to ReactiveNode#57710
AleksanderBodurri wants to merge 1 commit into
angular:mainfrom
AleksanderBodurri:signal-function-debug-names-primitive

Conversation

@AleksanderBodurri

@AleksanderBodurri AleksanderBodurri commented Sep 7, 2024

Copy link
Copy Markdown
Member

This commit contains the changes to core/primitives that used to be in #57073 but were moved for g3sync

@pullapprove pullapprove Bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Sep 7, 2024
@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Sep 7, 2024
@ngbot ngbot Bot added this to the Backlog milestone Sep 7, 2024
@AleksanderBodurri
AleksanderBodurri force-pushed the signal-function-debug-names-primitive branch from 7a28bf4 to 7c91874 Compare September 10, 2024 22:05
@AleksanderBodurri AleksanderBodurri mentioned this pull request Sep 12, 2024
Closed
@AleksanderBodurri AleksanderBodurri added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels Sep 20, 2024
@AleksanderBodurri

AleksanderBodurri commented Sep 20, 2024

Copy link
Copy Markdown
Member Author

Awaiting g3sync run @alxhub

@AleksanderBodurri AleksanderBodurri added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 23, 2024
alxhub
alxhub approved these changes Sep 24, 2024
View reviewed changes

@alxhub alxhub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs a change to the commit message to use refactor(core) instead of feat(core), because this is not a user visible feature.

@alxhub alxhub added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed requires: TGP This PR requires a passing TGP before merging is allowed labels Sep 24, 2024
@pullapprove pullapprove Bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Sep 24, 2024
@alxhub

alxhub commented Sep 24, 2024

Copy link
Copy Markdown
Member

Caretaker: TGP not required (type-only change, can't affect production)

@AleksanderBodurri
AleksanderBodurri force-pushed the signal-function-debug-names-primitive branch from 7c91874 to 6fee943 Compare September 27, 2024 00:04
@AleksanderBodurri AleksanderBodurri changed the title feat(core): introduce debugName optional arg to ReactiveNode refactor(core): introduce debugName optional arg to ReactiveNode Sep 27, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Sep 27, 2024
@ngbot ngbot Bot modified the milestone: Backlog Sep 27, 2024
@AleksanderBodurri AleksanderBodurri added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2024
@pullapprove
pullapprove Bot removed the request for review from atscott October 2, 2024 21:00
@AleksanderBodurri AleksanderBodurri removed the action: merge The PR is ready for merge by the caretaker label Oct 2, 2024
@AleksanderBodurri
refactor(core): introduce debugName optional arg to ReactiveNode
f6813b3 
This commit contains the changes to core/primitives that used to be in angular#57073.
@AleksanderBodurri
AleksanderBodurri force-pushed the signal-function-debug-names-primitive branch from 6fee943 to f6813b3 Compare October 2, 2024 21:08
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 2, 2024
@AleksanderBodurri AleksanderBodurri added the action: merge The PR is ready for merge by the caretaker label Oct 2, 2024
AndrewKushnir
AndrewKushnir approved these changes Oct 7, 2024
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir

AndrewKushnir commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

TESTED=No TGP required, see #57710 (comment).

@AndrewKushnir

AndrewKushnir commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 837af44.

The changes were merged into the following branches: main

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 7, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource
@tbondwilkinson tbondwilkinson Awaiting requested review from tbondwilkinson
@alxhub alxhub Awaiting requested review from alxhub

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note requires: TGP This PR requires a passing TGP before merging is allowed target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@AleksanderBodurri @alxhub @AndrewKushnir @dgp1130