Conversation
…runing Currently during the module pruning stage of the standalone migration we assume that any leftover modules which only have `imports` and `exports` can safely be removed. That can be incorrect for the cases where some parts of the app were converted to standalone outside of the migration. These changes update the logic so that such modules are replaced with the `exports` which are used within the specific component. Fixes angular#51420.
crisbeto
added
target: patch
crisbeto
added
the
action: review
devversion
approved these changes
Sep 6, 2024
crisbeto
added
action: merge
Contributor
|
This PR was merged into the repository by commit fc95a9a. The changes were merged into the following branches: main, 18.2.x |
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 6, 2024
…runing (#57684) Currently during the module pruning stage of the standalone migration we assume that any leftover modules which only have `imports` and `exports` can safely be removed. That can be incorrect for the cases where some parts of the app were converted to standalone outside of the migration. These changes update the logic so that such modules are replaced with the `exports` which are used within the specific component. Fixes #51420. PR Close #57684
This was referenced Sep 15, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Open
This was referenced Oct 3, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently during the module pruning stage of the standalone migration we assume that any leftover modules which only have
importsandexportscan safely be removed. That can be incorrect for the cases where some parts of the app were converted to standalone outside of the migration.These changes update the logic so that such modules are replaced with the
exportswhich are used within the specific component.Fixes #51420.