Skip to content

fix(http): Dynamicaly call the global fetch implementation - #57531

Closed
JeanMeche wants to merge 2 commits into
angular:mainfrom
JeanMeche:fix/http-global-fetch
Closed

fix(http): Dynamicaly call the global fetch implementation#57531
JeanMeche wants to merge 2 commits into
angular:mainfrom
JeanMeche:fix/http-global-fetch

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Aug 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Instead of using the reference that existed when FetchBackend was setup.

fixes #57527

@JeanMeche JeanMeche mentioned this pull request Aug 26, 2024
Closed
@JeanMeche
JeanMeche requested review from AndrewKushnir and removed request for pkozlowski-opensource August 26, 2024 19:54
@JeanMeche
JeanMeche force-pushed the fix/http-global-fetch branch 2 times, most recently from c13fe7a to eae4b45 Compare August 26, 2024 21:43
@AndrewKushnir AndrewKushnir added area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release action: presubmit The PR is in need of a google3 presubmit labels Aug 26, 2024
@ngbot ngbot Bot modified the milestone: Backlog Aug 26, 2024
@AndrewKushnir

AndrewKushnir commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Aug 26, 2024
@AndrewKushnir

AndrewKushnir commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Caretaker note: presubmit is "green", this PR is ready for merge.

BenoitZugmeyer
BenoitZugmeyer reviewed Aug 27, 2024
View reviewed changes
Comment thread packages/common/http/src/fetch.ts Outdated
@JeanMeche
JeanMeche force-pushed the fix/http-global-fetch branch from eae4b45 to a61b136 Compare August 27, 2024 08:16
@angular-robot
angular-robot Bot requested a review from AndrewKushnir August 27, 2024 08:16
@JeanMeche
fix(http): Dynamicaly call the global fetch implementation
35e0b21 
Instead of using the reference that existing when `FetchBackend` is setup.

fixes angular#57527
@JeanMeche
JeanMeche force-pushed the fix/http-global-fetch branch from a61b136 to 35e0b21 Compare August 27, 2024 08:18
@JeanMeche

JeanMeche commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

Latest change was just a comment update. Will require a re-review though.

@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Aug 27, 2024
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2024
@alxhub

alxhub commented Aug 27, 2024

Copy link
Copy Markdown
Member

This PR was merged into the repository by commit 21445a2.

The changes were merged into the following branches: main, 18.2.x

alxhub pushed a commit that referenced this pull request Aug 27, 2024
@JeanMeche @alxhub
fix(http): Dynamicaly call the global fetch implementation (#57531)
5d2e243 
Instead of using the reference that existing when `FetchBackend` is setup.

fixes #57527

PR Close #57531
@alxhub alxhub closed this in 21445a2 Aug 27, 2024
This was referenced Sep 26, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 27, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 30, 2024
Open
Open
This was referenced Sep 30, 2024
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 1, 2024
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Oct 4, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoostK JoostK JoostK left review comments
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
+1 more reviewer
@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

See More

Successfully merging this pull request may close these issues.

Allow late instrumentation of globalThis.fetch

6 participants

@JeanMeche @AndrewKushnir @alxhub @mvdluit @BenoitZugmeyer @JoostK