Skip to content

refactor(compiler-cli): add the ability to remove imports from the import manager - #57110

Closed
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:import-manager-remove
Closed

crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:import-manager-remove

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Extends the ImportManager to allow for imports to be removed. This will be useful in automated migrations.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release labels Jul 24, 2024
@ngbot ngbot Bot added this to the Backlog milestone Jul 24, 2024
@crisbeto
crisbeto requested a review from devversion July 24, 2024 13:15

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

Comment thread packages/compiler-cli/src/ngtsc/translator/src/import_manager/import_manager.ts Outdated
Comment thread packages/compiler-cli/src/ngtsc/translator/src/import_manager/import_manager.ts Outdated
Comment thread packages/compiler-cli/src/ngtsc/translator/src/import_manager/import_manager.ts Outdated
…port manager

Extends the `ImportManager` to allow for imports to be removed. This will be useful in automated migrations.
@crisbeto
crisbeto force-pushed the import-manager-remove branch from f82dd5d to bd221c1 Compare July 25, 2024 11:27
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 25, 2024
@dylhunn

dylhunn commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 2158b8d.

The changes were merged into the following branches: main

@dylhunn dylhunn closed this in 2158b8d Jul 26, 2024
crisbeto added a commit to crisbeto/angular that referenced this pull request Jul 29, 2024
… tracker

Updates the `ChangeTracker` to integrate the changes from angular#57110.
vladboisa pushed a commit to vladboisa/angular that referenced this pull request Jul 29, 2024
…port manager (angular#57110)

Extends the `ImportManager` to allow for imports to be removed. This will be useful in automated migrations.

PR Close angular#57110
dylhunn pushed a commit that referenced this pull request Jul 29, 2024
… tracker (#57179)

Updates the `ChangeTracker` to integrate the changes from #57110.

PR Close #57179
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants