Conversation
crisbeto
added
action: review
angular-robot
Bot
added
the
area: migrations
crisbeto
commented
Jul 23, 2024
Member
Author
There was a problem hiding this comment.
I can imagine this being inside the ImportManager as well.
Member
There was a problem hiding this comment.
Haha, I was thinking this logic feels more specific to the schematic portion 😄
Member
Author
There was a problem hiding this comment.
It might make sense to have this in the ImportManager too, but it's also fairly basic.
Member
There was a problem hiding this comment.
Agreed. Maybe it can be a set of common helpers in the import manager directory.
devversion
approved these changes
Jul 23, 2024
Member
There was a problem hiding this comment.
Haha, I was thinking this logic feels more specific to the schematic portion 😄
Member
There was a problem hiding this comment.
Agreed. Maybe it can be a set of common helpers in the import manager directory.
crisbeto
force-pushed
the
schematics-import-manager
branch
from
July 23, 2024 16:22
ebb7058 to
39bde3b
Compare
Updates the import manager to allow for a specific alias to be passed in. This is a prerequisite for switching schematics to the new import manager. Note that passing in an alias disables identifier conflict resolution in order to avoid rewriting the alias that was passed in explicitly. For now this is fine since we have a very narrow use case for it, but we may want to revisit it in the future.
Fixes that the `ImportManager` wasn't picking up some of its configuration options.
Updates the schematics to reuse the common `ImportManager`, instead of having to maintain a separate one.
crisbeto
force-pushed
the
schematics-import-manager
branch
from
July 23, 2024 16:39
39bde3b to
4d7bf17
Compare
crisbeto
added
action: merge
Contributor
|
This PR was merged into the repository by commit bb977e0. The changes were merged into the following branches: main |
atscott
pushed a commit
that referenced
this pull request
Jul 23, 2024
Updates the schematics to reuse the common `ImportManager`, instead of having to maintain a separate one. PR Close #57096
5 of 14 tasks
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
…ar#57096) Updates the import manager to allow for a specific alias to be passed in. This is a prerequisite for switching schematics to the new import manager. Note that passing in an alias disables identifier conflict resolution in order to avoid rewriting the alias that was passed in explicitly. For now this is fine since we have a very narrow use case for it, but we may want to revisit it in the future. PR Close angular#57096
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
…ngular#57096) Fixes that the `ImportManager` wasn't picking up some of its configuration options. PR Close angular#57096
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
…ar#57096) Updates the schematics to reuse the common `ImportManager`, instead of having to maintain a separate one. PR Close angular#57096
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following changes which allow us to delete one import manager implementation in favor of a common one.
refactor(compiler-cli): add alias option to the import manager
Updates the import manager to allow for a specific alias to be passed in. This is a prerequisite for switching schematics to the new import manager.
Note that passing in an alias disables identifier conflict resolution in order to avoid rewriting the alias that was passed in explicitly. For now this is fine since we have a very narrow use case for it, but we may want to revisit it in the future.
refactor(compiler-cli): import manager not picking up some options
Fixes that the
ImportManagerwasn't picking up some of its configuration options.refactor(migrations): use common import manager for schematics
Updates the schematics to reuse the common
ImportManager, instead of having to maintain a separate one.