Skip to content

fix(core): Deprecate ignoreChangesOutsideZone option - #57029

Closed
atscott wants to merge 1 commit into
angular:mainfrom
atscott:deprecateIgnoreOutsideZone
Closed

atscott wants to merge 1 commit into
angular:mainfrom
atscott:deprecateIgnoreOutsideZone

Conversation

@atscott

@atscott atscott commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

This option was introduced out of caution as a way for developers to opt out of the new behavior in v18 which schedule change detection for the above events when they occur outside the Zone. After monitoring the results post-release, we have determined that this feature is working as desired and do not believe it should ever be disabled by setting this option to true.

@atscott atscott added the target: minor This PR is targeted for the next minor release label Jul 17, 2024
@atscott
atscott requested a review from alxhub July 17, 2024 20:52
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Jul 17, 2024
@ngbot ngbot Bot added this to the Backlog milestone Jul 17, 2024
This option was introduced out of caution as a way for developers to opt out of the new behavior in v18 which schedule change detection for the above events when they occur outside the Zone. After monitoring the results post-release, we have determined that this feature is working as desired and do not believe it should ever be disabled by setting this option to `true`.
@atscott
atscott force-pushed the deprecateIgnoreOutsideZone branch from 7ceffef to e0a8474 Compare July 19, 2024 01:57

@pkozlowski-opensource pkozlowski-opensource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@pullapprove
pullapprove Bot requested a review from thePunderWoman July 23, 2024 16:26
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jul 23, 2024

@thePunderWoman thePunderWoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott

atscott commented Jul 23, 2024

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository by commit 8718abc.

The changes were merged into the following branches: main

@atscott atscott closed this in 8718abc Jul 23, 2024
vladboisa pushed a commit to vladboisa/angular that referenced this pull request Jul 29, 2024
This option was introduced out of caution as a way for developers to opt out of the new behavior in v18 which schedule change detection for the above events when they occur outside the Zone. After monitoring the results post-release, we have determined that this feature is working as desired and do not believe it should ever be disabled by setting this option to `true`.

PR Close angular#57029
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants