Conversation
atscott
approved these changes
Jul 10, 2024
alxhub
force-pushed
the
appref-dirty
branch
2 times, most recently
from
July 17, 2024 15:31
0a8da84 to
111369c
Compare
alxhub
added
requires: TGP
pullapprove
Bot
removed
the
requires: TGP
alxhub
force-pushed
the
appref-dirty
branch
2 times, most recently
from
July 17, 2024 15:48
2f1908a to
cfb7bfa
Compare
Previously the zoneless scheduler had a concept of whether views needed to be refreshed or not, based on the notification type that was received. It tracked this information as a boolean. This commit refactors things to track dirtiness in `ApplicationRef` itself, as a `dirtyFlags` field with bits corresponding to either view tree dirtiness or after-render hooks.
Member
Author
|
Closing in favor of #57453 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the zoneless scheduler had a concept of whether views needed to be refreshed or not, based on the notification type that was received. It tracked this information as a boolean.
This commit refactors things to track dirtiness in
ApplicationRefitself, as adirtyFlagsfield with bits corresponding to either view tree dirtiness or after-render hooks.