Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
angular-robot
Bot
added
the
area: compiler
AndrewKushnir
requested review from
crisbeto
and removed request for
AndrewKushnir
July 10, 2024 21:44
Replace loose equality (==) with strict equality (===) for the 'code' variable. This change ensures type safety and prevents unintended type coercion.
Contributor
Author
|
sorry I created the same PR again with updated commit msg |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The code uses a loose equality comparison (==) for the code variable.
Issue Number: N/A
What is the new behavior?
The code now uses strict equality comparison (===) for the code variable, ensuring type safety and preventing unintended type coercion.
Does this PR introduce a breaking change?
Other information
this was introduces in v18.1.0 release, in this PR:
#56764