Conversation
4 of 14 tasks
AndrewKushnir
approved these changes
Jun 20, 2024
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
@cexbrayat thanks for creating a PR for the 18.0.x branch.
AndrewKushnir
added
action: merge
Contributor
|
@cexbrayat do you mind rebasing it on top of the most recent 18.0.x branch? There were some additional commits there that fixed CI issues. |
AndrewKushnir
added
action: cleanup
This commit improves the documentation of the options parameter of the afterRender hooks.
cexbrayat
force-pushed
the
fix/after-render-phase-warning-typo
branch
from
June 20, 2024 20:54
8addf2a to
049c536
Compare
Member
Author
|
@AndrewKushnir Sure, done! |
AndrewKushnir
approved these changes
Jun 20, 2024
AndrewKushnir
added
action: merge
Contributor
|
This PR was merged into the repository by commit 2f73281. The changes were merged into the following branches: 18.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 20, 2024
This commit improves the documentation of the options parameter of the afterRender hooks. PR Close #56525
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
This commit improves the documentation of the options parameter of the afterRender hooks.
Does this PR introduce a breaking change?
Other information
This is a rebased version of #56522 on the v18 branch as asked by @AndrewKushnir