feat(core): expose signal input metadata in ComponentMirror - #56402
Closed
devversion wants to merge 2 commits into
Closed
devversion wants to merge 2 commits into
devversion wants to merge 2 commits into
Conversation
This commit starts exposing `isSignal` for inputs in the `ComponentMirror`. We initially had this as a draft when rolling out signal inputs, but there were no good use-cases, so we skipped it. Now, inside G3, for the testing infrastructure and rolling out advancements for signal inputs, having this information is necessary and allows identifying signal inputs without "accessing fields" on the class that may cause side-effects (like triggering setters).
devversion
force-pushed
the
feat-expose-signal-input-info
branch
from
June 12, 2024 13:04
4752974 to
cdedd52
Compare
devversion
changed the title
ComponentMirror.ComponentMirror
devversion
added
action: review
devversion
marked this pull request as ready for review
June 12, 2024 13:21
crisbeto
approved these changes
Jun 12, 2024
Small perf improvement
devversion
requested review from
thePunderWoman
and removed request for
pkozlowski-opensource
June 12, 2024 17:43
thePunderWoman
approved these changes
Jun 12, 2024
thePunderWoman
approved these changes
Jun 12, 2024
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: fw-core, fw-elements, public-api
atscott
approved these changes
Jun 12, 2024
atscott
left a comment
atscott
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
removed their request for review
June 12, 2024 18:52
devversion
added
action: merge
Contributor
|
This PR was merged into the repository by commit 352e078. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit starts exposing
isSignalfor inputs in theComponentMirror. We initially had this as a draft when rolling out signal inputs, but there were no good use-cases, so we skipped it.Now, inside G3, for the testing infrastructure and rolling out advancements for signal inputs, having this information is necessary and allows identifying signal inputs without "accessing fields" on the class that may cause side-effects (like triggering setters).