Conversation
crisbeto
added
area: build & ci
crisbeto
force-pushed
the
ts-5.5-rc
branch
2 times, most recently
from
June 10, 2024 21:41
8224da2 to
fe7459e
Compare
crisbeto
added
the
action: review
crisbeto
marked this pull request as ready for review
June 10, 2024 21:41
pullapprove
Bot
requested review from
alxhub,
pkozlowski-opensource and
thePunderWoman
June 11, 2024 18:23
thePunderWoman
approved these changes
Jun 11, 2024
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
approved these changes
Jun 11, 2024
Member
Author
|
I'm holding this PR back for a bit because we're still talking with Alex if it's the right way to resolve one of the issues that popped up. |
pkozlowski-opensource
approved these changes
Jun 14, 2024
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Jun 21, 2024
Updates the repo to the stable version of TypeScript 5.5. I'm holding off on updating the new projects to it due to angular/angular#56358.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Jun 21, 2024
Updates the repo to the stable version of TypeScript 5.5. I'm holding off on updating the new projects to it due to angular/angular#56358.
crisbeto
changed the title
crisbeto
changed the title
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Jun 21, 2024
Updates the repo to the stable version of TypeScript 5.5. I'm holding off on updating the new projects to it due to angular/angular#56358.
alan-agius4
pushed a commit
to angular/angular-cli
that referenced
this pull request
Jun 21, 2024
Updates the repo to the stable version of TypeScript 5.5. I'm holding off on updating the new projects to it due to angular/angular#56358.
crisbeto
force-pushed
the
ts-5.5-rc
branch
2 times, most recently
from
June 24, 2024 08:17
42a0022 to
1afa6fe
Compare
Updates the repo to the stable release of TypeScript 5.5.
crisbeto
commented
Jun 24, 2024
| getSourceFile(fileName: string, languageVersion: ts.ScriptTarget): ts.SourceFile | undefined { | ||
| const text = this.readFile(fileName); | ||
| return text !== undefined | ||
| ? ts.createSourceFile( |
Member
Author
There was a problem hiding this comment.
The context here is that I had to make this change during the update to the TS 5.5 beta, but it's no longer necessary for the RC/final.
alxhub
approved these changes
Jun 24, 2024
crisbeto
added
action: merge
1 task
Contributor
|
This PR was merged into the repository by commit ccc8c80. The changes were merged into the following branches: main |
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Jun 26, 2024
Now that angular/angular#56358 is on track for 18.1, we can use TypeScript 5.5 for newly-created projects and in tests.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Jun 26, 2024
Now that angular/angular#56358 is on track for 18.1, we can use TypeScript 5.5 for newly-created projects and in tests.
dgp1130
pushed a commit
to angular/angular-cli
that referenced
this pull request
Jun 26, 2024
Now that angular/angular#56358 is on track for 18.1, we can use TypeScript 5.5 for newly-created projects and in tests.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Jul 12, 2024
… 5.4 In angular#56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references. These changes add tagging right before the program emits. Fixes angular#56945.
atscott
pushed a commit
that referenced
this pull request
Jul 15, 2024
… 5.4 (#56961) In #56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references. These changes add tagging right before the program emits. Fixes #56945. PR Close #56961
atscott
pushed a commit
that referenced
this pull request
Jul 15, 2024
… 5.4 (#56961) In #56358 we removed most of the places that untag the references to typecheck files, because it was causing the compiler to throw error when it produces diagnostics. This appears to have caused a regression in TS 5.4 which now emits the synthetic references. These changes add tagging right before the program emits. Fixes #56945. PR Close #56961
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the repo to the stable release of TypeScript 5.5.