refactor(core): WIP - partial hydration prototype - #56311
Closed
thePunderWoman wants to merge 19 commits into
Closed
thePunderWoman wants to merge 19 commits into
thePunderWoman wants to merge 19 commits into
Conversation
thePunderWoman
force-pushed
the
partial-hydration-prototype
branch
3 times, most recently
from
June 13, 2024 18:28
5cd9091 to
7a8fb19
Compare
thePunderWoman
force-pushed
the
partial-hydration-prototype
branch
from
June 13, 2024 19:47
7a8fb19 to
ed9fa93
Compare
thePunderWoman
force-pushed
the
partial-hydration-prototype
branch
9 times, most recently
from
July 23, 2024 21:12
4eaaad5 to
d532715
Compare
thePunderWoman
force-pushed
the
partial-hydration-prototype
branch
10 times, most recently
from
July 30, 2024 20:46
57c97e3 to
43320ca
Compare
thePunderWoman
force-pushed
the
partial-hydration-prototype
branch
from
August 2, 2024 21:09
065d394 to
056f50c
Compare
thePunderWoman
force-pushed
the
partial-hydration-prototype
branch
9 times, most recently
from
August 21, 2024 22:34
4a39580 to
58b8d4d
Compare
This is a work in progress of the prototype of partial hydration using defer blocks
this adds support in the defer block ast to parse hydrate statements for partial hydration.
This adds the set of instructions to support usage of hydrate in defer blocks
The hydration test file is giant. This breaks it up into full app and partial files.
This separates out the full app hydration and partial hydration tests, adds a bunch, and adds ngh annotations for defer blocks.
Lets test it out! It WORKS! IT WORKS!
this adds serialized defer block details for partial hydration
This should be able to look through and find all the nodes with ngh and the appropriate triggers for partial hydration.
This adds non-jsaction events and starts to get them working
This adds functionality for all the partial hydration triggers.
This adds a never hydrate trigger.
this ensures the injection of the partial hydration token is optional and defaults to false.
this adds hydrate cleanup to trigger cleanup invocation.
defer triggers would be called regardless of the hydrate trigger presence. This ensures they are not called when on initial load and have a hydrate flag.
Partial hydration cases are nuanced in when they need to be cleaned up. This adds the right conditions to avoid over and under cleaning up of nodes.
Hydrate viewport will always be adjacent to a defer trigger. So hydrate triggers should never cause a missing placeholder error to occur.
In some cases, hydrate triggers were being used as a default due to a problem in the ingest parsing. This ensures idle is added as default in the right cases.
event replay was firing too early in some cases due to an early return of a null.
cleanup was causing overzealous removal of content because the app was not yet stable.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.