Conversation
atscott
added
area: forms
requires: TGP
atscott
force-pushed
the
formshostbindingsonpush
branch
4 times, most recently
from
May 10, 2024 00:59
5e83ed8 to
90a620a
Compare
This was referenced May 11, 2024
atscott
force-pushed
the
formshostbindingsonpush
branch
5 times, most recently
from
May 23, 2024 19:52
dbb8263 to
2911043
Compare
atscott
marked this pull request as ready for review
May 23, 2024 19:52
pullapprove
Bot
removed
the
requires: TGP
JeanMeche
approved these changes
May 23, 2024
AndrewKushnir
removed their request for review
May 23, 2024 22:48
atscott
force-pushed
the
formshostbindingsonpush
branch
2 times, most recently
from
May 29, 2024 15:58
a4d7c44 to
9afe197
Compare
dylhunn
approved these changes
May 29, 2024
dylhunn
left a comment
dylhunn
left a comment
Contributor
There was a problem hiding this comment.
This is the PR that had issues when groups are passed into OnPush sibling components, right?
pullapprove
Bot
requested review from
alxhub,
pkozlowski-opensource and
thePunderWoman
May 29, 2024 22:17
thePunderWoman
approved these changes
May 30, 2024
thePunderWoman
left a comment
thePunderWoman
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
Yes, that's right. It's maybe on the border of what might be considered a breaking change. |
AndrewKushnir
approved these changes
May 30, 2024
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
atscott
force-pushed
the
formshostbindingsonpush
branch
2 times, most recently
from
June 6, 2024 16:48
8b65e7e to
a87a3cb
Compare
This commit makes the host bindings of `NgControlStatus[Group]` compatible with `OnPush` components. Note that this intentionally _does not_ expose any new APIs in the forms module. The goal is only to remove unpreventable `ExpressionChangedAfterItHasBeenCheckedError` in the forms code that developers do not have control over.
atscott
force-pushed
the
formshostbindingsonpush
branch
from
June 14, 2024 21:10
a87a3cb to
91a35e9
Compare
Contributor
Author
atscott
force-pushed
the
formshostbindingsonpush
branch
from
June 18, 2024 17:02
91a35e9 to
237b6f2
Compare
AndrewKushnir
added
action: merge
Contributor
|
This PR was merged into the repository by commit 00bde8b. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the host bindings of
NgControlStatus[Group]compatible withOnPushcomponents. Note that this intentionally does not expose any new APIs in the forms module. The goal is only to remove unpreventableExpressionChangedAfterItHasBeenCheckedErrorin the forms code that developers do not have control over.