Conversation
alxhub
approved these changes
Apr 18, 2024
Contributor
Author
atscott
added
the
merge: caretaker note
Contributor
Author
|
caretaker note: CI failure is failing at HEAD, not from this PR |
… (part 2) This commit prevents doubling change detections when the zoneless scheduler is notified first, followed by the zone becomeing unstable (effectively "scheduling" zone-based change detection). When run coalescing is enabled, this would otherwise result in the zoneless scheduler running change detection first and then change detection running again because of the run coalescing since both scheduler use the same timing function (and then it would be FIFO).
atscott
removed
the
merge: caretaker note
AndrewKushnir
added
target: rc
Contributor
|
This PR was merged into the repository by commit 356ec65. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2024
… (part 2) (#55403) This commit prevents doubling change detections when the zoneless scheduler is notified first, followed by the zone becomeing unstable (effectively "scheduling" zone-based change detection). When run coalescing is enabled, this would otherwise result in the zoneless scheduler running change detection first and then change detection running again because of the run coalescing since both scheduler use the same timing function (and then it would be FIFO). PR Close #55403
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prevents doubling change detections when the zoneless scheduler is notified first, followed by the zone becoming unstable (effectively "scheduling" zone-based change detection). When run coalescing is enabled, this would otherwise result in the zoneless scheduler running change detection first and then change detection running again because of the run coalescing since both scheduler use the same timing function (and then it would be FIFO).