Conversation
atscott
force-pushed
the
doubleTickWithCoalescing
branch
4 times, most recently
from
April 15, 2024 20:48
13a98fa to
bd7b933
Compare
pkozlowski-opensource
added
the
area: core
atscott
force-pushed
the
doubleTickWithCoalescing
branch
3 times, most recently
from
April 16, 2024 20:00
848a24e to
9a8cbf5
Compare
atscott
force-pushed
the
doubleTickWithCoalescing
branch
from
April 16, 2024 22:45
9a8cbf5 to
4080d18
Compare
atscott
force-pushed
the
doubleTickWithCoalescing
branch
from
April 17, 2024 18:53
4080d18 to
35e4d73
Compare
…scing and zoneless This commit ensures we correctly handle the exit from the zone.run in the zoneless scheduler. Run coalescing would delay the `onMicrotaskEmpty` event until after we have exited the change detection triggered by the zoneless scheduler and mean that the subscription cannot determine if `ApplicationRef.tick` should be skipped.
atscott
force-pushed
the
doubleTickWithCoalescing
branch
from
April 17, 2024 18:54
35e4d73 to
129d4bd
Compare
alxhub
approved these changes
Apr 17, 2024
Member
|
This PR was merged into the repository by commit 18a43b5. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures we correctly handle the exit from the zone.run in
the zoneless scheduler. Run coalescing would delay the
onMicrotaskEmptyeventuntil after we have exited the change detection triggered by the
zoneless scheduler and mean that the subscription cannot determine if
ApplicationRef.tickshould be skipped.