Prevent extra change detections in zoneless scheduler with manual calls to ApplicationRef.tick - #55290
Closed
atscott wants to merge 3 commits into
Closed
Prevent extra change detections in zoneless scheduler with manual calls to ApplicationRef.tick#55290atscott wants to merge 3 commits into
atscott wants to merge 3 commits into
Conversation
atscott
added
area: core
atscott
force-pushed
the
appreftick
branch
3 times, most recently
from
April 11, 2024 02:10
2773c28 to
c70641a
Compare
…f.tick This commit ensures that change detection is not scheduled if the scheduler is notified during an applicationRef.tick
…hange detections This commit ensures that manually calling ApplicationRef.tick will result in any scheduled change detections being canceled. There is no need for the scheduled one to run because it was manually done by the `tick` already.
atscott
force-pushed
the
appreftick
branch
2 times, most recently
from
April 15, 2024 16:17
c19667d to
9266108
Compare
alxhub
approved these changes
Apr 15, 2024
…duled change detections
atscott
added
the
merge: caretaker note
Contributor
Author
|
merge assistance: will need to patch messages custom implementation from cl/625061775 |
Member
|
This PR was merged into the repository by commit 785c3c1. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits