Skip to content

Devtools fixes - #54912

Closed
JeanMeche wants to merge 4 commits into
angular:mainfrom
JeanMeche:devtools/fix-signal
Closed

Devtools fixes #54912
JeanMeche wants to merge 4 commits into
angular:mainfrom
JeanMeche:devtools/fix-signal

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Mar 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

See individual commits.

fixes #53704

@JeanMeche JeanMeche changed the title Devtools/fix signal Devtools fixes Mar 17, 2024
@JeanMeche
JeanMeche force-pushed the devtools/fix-signal branch 4 times, most recently from 75c4bf0 to 12a8922 Compare March 17, 2024 15:08
@JeanMeche
JeanMeche marked this pull request as ready for review March 19, 2024 12:13
@ngbot ngbot Bot added this to the Backlog milestone Mar 27, 2024
@JeanMeche JeanMeche mentioned this pull request Apr 16, 2024
Closed
dgp1130
dgp1130 requested changes Apr 17, 2024
View reviewed changes

@dgp1130 dgp1130 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together and apologies for the review delay. No major concerns, I think you just dropped a file in your stopPropagation commit.

@AleksanderBodurri, can you take a quick look as well just to make sure I'm not missing anything?

Comment thread ...ools/src/lib/devtools-tabs/directive-explorer/directive-forest/directive-forest.component.ts Outdated

@dgp1130 dgp1130 Apr 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is this used anywhere? Was this referenced in the template somewhere and dropped from this commit?

@JeanMeche JeanMeche Apr 17, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not sure why the change was missing, It's back now.

Comment thread ...ls/src/lib/devtools-tabs/directive-explorer/directive-forest/directive-forest.component.html Outdated

@dgp1130 dgp1130 Apr 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: One of my points of feedback was that it's not super clear what was "Mismatched", especially for users not that familiar with hydration. Should we update these tool tips to actually use the word "hydration" such as "Hydration skipped" and "Hydration mismatch"? That way a developer would have something meaningful to search for if they want to understand what exactly this means.

dgp1130
dgp1130 approved these changes Apr 17, 2024
View reviewed changes

@dgp1130 dgp1130 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

My one other minor suggestion is a brief comment either on (dblclick) or stopPropogation about the action it's trying to prevent, since it's purpose doesn't seem super obvious to me.

@AleksanderBodurri AleksanderBodurri added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 25, 2024
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Apr 25, 2024
@AndrewKushnir

AndrewKushnir commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

@JeanMeche the merge tooling failed to process this PR. Could you please rebase on top of the most recent main and merge fixup commits into corresponding parent commits? Merging fixup commits is automatic in the tooling, but for some reasons failed for this PR.

@JeanMeche
refactor(devtools): fix issue with virtual scroll viewport in the dir…
569c041 
…ective forest

In some cases the height of the viewport wasn't calculated correctly because of extension tabs quirks. This commit fixes this issue.

Fixes angular#53704
@JeanMeche
refactor(devtools): improve signal support.
fe6af0a 
In some cases signals weren't unwraped thus not reading the value correctly. This commit fixes this issue.
@JeanMeche
JeanMeche force-pushed the devtools/fix-signal branch from b67d98e to 796c2f2 Compare April 25, 2024 21:36
@JeanMeche
JeanMeche force-pushed the devtools/fix-signal branch from 796c2f2 to 0b1c58e Compare April 25, 2024 21:38
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 25, 2024
@JeanMeche

JeanMeche commented Apr 25, 2024

Copy link
Copy Markdown
Member Author

We should be ✅ now

@AndrewKushnir

AndrewKushnir commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 96972b4.

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): fix issue with virtual scroll viewport in the dir…
621f598 
…ective forest (#54912)

In some cases the height of the viewport wasn't calculated correctly because of extension tabs quirks. This commit fixes this issue.

Fixes #53704

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): improve signal support. (#54912)
c5c7ec9 
In some cases signals weren't unwraped thus not reading the value correctly. This commit fixes this issue.

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): prevent dblclick on the expand arrow to show the …
85feab2 
…element panel (#54912)

This will improve the UX

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): hide hydration error when the component tree is c…
a39f2ff 
…ollapsed (#54912)

This commit improves the devtools UX.

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): improve signal support. (#54912)
54de0f3 
In some cases signals weren't unwraped thus not reading the value correctly. This commit fixes this issue.

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): prevent dblclick on the expand arrow to show the …
e0096ef 
…element panel (#54912)

This will improve the UX

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): hide hydration error when the component tree is c…
96972b4 
…ollapsed (#54912)

This commit improves the devtools UX.

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): fix issue with virtual scroll viewport in the dir…
ce094b2 
…ective forest (#54912)

In some cases the height of the viewport wasn't calculated correctly because of extension tabs quirks. This commit fixes this issue.

Fixes #53704

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): improve signal support. (#54912)
5530c5e 
In some cases signals weren't unwraped thus not reading the value correctly. This commit fixes this issue.

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): prevent dblclick on the expand arrow to show the …
4a33efa 
…element panel (#54912)

This will improve the UX

PR Close #54912
AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@JeanMeche @AndrewKushnir
refactor(devtools): hide hydration error when the component tree is c…
507d83d 
…ollapsed (#54912)

This commit improves the devtools UX.

PR Close #54912
@JeanMeche
JeanMeche deleted the devtools/fix-signal branch April 25, 2024 22:40
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented May 26, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dgp1130 dgp1130 dgp1130 approved these changes
@AleksanderBodurri AleksanderBodurri AleksanderBodurri approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: devtools target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Virtual scroll positioning

5 participants

@JeanMeche @AndrewKushnir @dgp1130 @AleksanderBodurri @dylhunn