Skip to content

fix(core): generic inference for signal inputs may break with --strictFunctionTypes #54652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devversion wants to merge 1 commit into from
Closed

fix(core): generic inference for signal inputs may break with --strictFunctionTypes #54652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler-cli/src/ngtsc/testing/fake_core/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export interface InputFunction {
export const input: InputFunction = null!;

export type ɵUnwrapInputSignalWriteType<Field> =
Field extends InputSignalWithTransform<unknown, infer WriteT>? WriteT : never;
Field extends InputSignalWithTransform<any, infer WriteT>? WriteT : never;
export type ɵUnwrapDirectiveSignalInputs<Dir, Fields extends keyof Dir> = {
[P in Fields]: ɵUnwrapInputSignalWriteType<Dir[P]>
};
Expand Down
14 changes: 12 additions & 2 deletions packages/compiler-cli/src/ngtsc/typecheck/test/test_case_helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
* found in the LICENSE file at https://angular.io/license
*/

import ts from 'typescript';

import {TypeCheckingConfig} from '../api';
import {diagnose} from '../testing';

Expand Down Expand Up @@ -54,7 +56,7 @@ export interface TestCase {
* Diagnoses the given test case, by constructing the test TypeScript file
* and running the type checker on it.
*/
export function typeCheckDiagnose(c: TestCase) {
export function typeCheckDiagnose(c: TestCase, compilerOptions?: ts.CompilerOptions) {
const inputs = c.inputs ?? {};
const outputs = c.outputs ?? {};

Expand Down Expand Up @@ -124,7 +126,7 @@ export function typeCheckDiagnose(c: TestCase) {
.map(([name]) => name),
},
],
undefined, c.options);
undefined, c.options, compilerOptions);

expect(messages).toEqual(c.expected);
}
Expand All @@ -136,4 +138,12 @@ export function generateDiagnoseJasmineSpecs(cases: TestCase[]): void {
typeCheckDiagnose(c);
});
}

describe('with `--strict`', () => {
for (const c of cases) {
(c.focus ? fit : it)(c.id, () => {
typeCheckDiagnose(c, {strict: true});
});
}
});
}
2 changes: 1 addition & 1 deletion packages/core/src/authoring/input/input_type_checking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {InputSignalWithTransform} from './input_signal';

/** Retrieves the `WriteT` of an `InputSignal` and `InputSignalWithTransform`. */
export type ɵUnwrapInputSignalWriteType<Field> =
Field extends InputSignalWithTransform<unknown, infer WriteT>? WriteT : never;
Field extends InputSignalWithTransform<any, infer WriteT>? WriteT : never;

/**
* Unwraps all `InputSignal`/`InputSignalWithTransform` class fields of
Expand Down