Skip to content

fix(core): host directives incorrectly validating aliased bindings #50364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crisbeto wants to merge 1 commit into from
Closed

fix(core): host directives incorrectly validating aliased bindings #50364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions packages/compiler-cli/test/ngtsc/host_directives_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,59 @@ runInEachFileSystem(() => {

expect(messages).toEqual([]);
});

Copy link
Copy Markdown
Member Author

@crisbeto crisbeto May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the error being fixed here was only in the runtime, not the compiler. I ported the tests over to the compiler for consistency.

it('should not produce a diagnostic when exposing an aliased binding', () => {
env.write('test.ts', `
import {Directive, EventEmitter} from '@angular/core';

@Directive({
outputs: ['opened: triggerOpened'],
selector: '[trigger]',
standalone: true,
})
export class Trigger {
opened = new EventEmitter();
}

@Directive({
standalone: true,
selector: '[host]',
hostDirectives: [{directive: Trigger, outputs: ['triggerOpened']}]
})
export class Host {}
`);

const diags = env.driveDiagnostics();
expect(diags.length).toBe(0);
});

it('should not produce a diagnostic when exposing an inherited aliased binding', () => {
env.write('test.ts', `
import {Directive, EventEmitter} from '@angular/core';

@Directive({standalone: true})
export abstract class Base {
opened = new EventEmitter();
}

@Directive({
outputs: ['opened: triggerOpened'],
selector: '[trigger]',
standalone: true,
})
export class Trigger extends Base {}

@Directive({
standalone: true,
selector: '[host]',
hostDirectives: [{directive: Trigger, outputs: ['triggerOpened: hostOpened']}]
})
export class Host {}
`);

const diags = env.driveDiagnostics();
expect(diags.length).toBe(0);
});
});
});
});
2 changes: 1 addition & 1 deletion packages/core/src/render3/features/host_directives_feature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ function validateMappings(

const remappedPublicName = hostDirectiveBindings[publicName];

if (bindings.hasOwnProperty(remappedPublicName) &&
if (bindings.hasOwnProperty(remappedPublicName) && remappedPublicName !== publicName &&
bindings[remappedPublicName] !== publicName) {
throw new RuntimeError(
RuntimeErrorCode.HOST_DIRECTIVE_CONFLICTING_ALIAS,
Expand Down
60 changes: 60 additions & 0 deletions packages/core/test/acceptance/host_directives_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3219,5 +3219,65 @@ describe('host directives', () => {
fixture.detectChanges();
}).not.toThrow();
});

it('should not throw when exposing an aliased binding', () => {
@Directive({
outputs: ['opened: triggerOpened'],
selector: '[trigger]',
standalone: true,
})
class Trigger {
opened = new EventEmitter();
}

@Directive({
standalone: true,
selector: '[host]',
hostDirectives: [{directive: Trigger, outputs: ['triggerOpened']}]
})
class Host {
}

@Component({template: '<div host></div>', standalone: true, imports: [Host]})
class App {
}

expect(() => {
const fixture = TestBed.createComponent(App);
fixture.detectChanges();
}).not.toThrow();
});

it('should not throw when exposing an inherited aliased binding', () => {
@Directive({standalone: true})
abstract class Base {
opened = new EventEmitter();
}

@Directive({
outputs: ['opened: triggerOpened'],
selector: '[trigger]',
standalone: true,
})
class Trigger extends Base {
}

@Directive({
standalone: true,
selector: '[host]',
hostDirectives: [{directive: Trigger, outputs: ['triggerOpened: hostOpened']}]
})
class Host {
}

@Component({template: '<div host></div>', standalone: true, imports: [Host]})
class App {
}

expect(() => {
const fixture = TestBed.createComponent(App);
fixture.detectChanges();
}).not.toThrow();
});
});
});