Skip to content

fix(ng-content): wildcard ng-content has to go last. - #5016

Closed
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:ngcontent-fix
Closed

tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:ngcontent-fix

Conversation

@tbosch

@tbosch tbosch commented Oct 29, 2015

Copy link
Copy Markdown
Contributor

This was the case before the new compiler landed and should be preserved.

Related to #4598

This was the case before the new compiler landed and should be preserved. 

Related to angular#4598

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outside the scope of this PR, but we should do something about our test code readability. This is hardly readable.

@tbosch tbosch closed this in 39626a9 Oct 29, 2015
@tbosch
tbosch deleted the ngcontent-fix branch October 29, 2015 23:51
@pkozlowski-opensource

Copy link
Copy Markdown
Member

Yay, was bumping into this one yesterday. Thnx @tbosch !

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants