Repository navigation
Conversation
alexeagle
added
the
action: review
mhevery
added
pr_state: LGTM
and removed
action: review
|
Merging PR #4928 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4928. |
mary-poppins
removed
the
action: merge
There was a problem hiding this comment.
\n\r ?!? Is this a typo (here and below) ?
There was a problem hiding this comment.
No, I think this is intentionally adding cross-platform line breaks to make the generated script look a certain way. Or do you mean the ordering of the CR / LF characters differs between the two?
My tendency is to make the smaller change here and leave those alone...
There was a problem hiding this comment.
Yes, I meant about the order. \n\r isn't quite cross-platform (Windows needs \r\n - I guess that was the intention, unless I'm missing something).
Not a big deal though. Just whitespace differences at worst :)
|
Merging PR #4928 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4928. |
mary-poppins
removed
the
action: merge
Also clean up unused typings generation; we publish the node tree, not browser tree. Fixes angular#4882
|
Merging PR #4928 on behalf of @alexeagle to branch presubmit-alexeagle-pr-4928. |
mary-poppins
removed
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Also clean up unused typings generation; we publish the node tree, not browser tree.
Fixes #4882