Skip to content

Upgrade - #4766

Closed
mhevery wants to merge 4 commits into
angular:masterfrom
mhevery:upgrade
Closed

Upgrade#4766
mhevery wants to merge 4 commits into
angular:masterfrom
mhevery:upgrade

Conversation

@mhevery

@mhevery mhevery commented Oct 15, 2015

Copy link
Copy Markdown
Contributor

No description provided.

BREAKING CHANGE:

- Changes the terminology to Adapter and upgrade/downgrade
- Removes the Module from the public API to prevent confusion
The adapter only compiles ng1 template. This means that we need to 
reimplement / emulate all of the ng1’s API on the HOST element.


interface IDirective {
  compile?: IDirectiveCompileFn;               // NOT SUPPORTED
  controller?: any;                            // IMPLEMENTED
  controllerAs?: string;                       // IMPLEMENTED
  bindToController?: boolean|Object;           // IMPLEMENTED
  link?: IDirectiveLinkFn | IDirectivePrePost; // IMPLEMENTED (pre-link only)
  name?: string;                               // N/A
  priority?: number;                           // NOT SUPPORTED
  replace?: boolean;                           // NOT SUPPORTED
  require?: any;                               // IMPLEMENTED
  restrict?: string;                           // WORKING
  scope?: any;                                 // IMPLEMENTED
  template?: any;                              // IMPLEMENTED
  templateUrl?: any;                           // IMPLEMENTED
  terminal?: boolean;                          // NOT SUPPORTED
  transclude?: any;                            // IMPLEMENTED
}
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 15, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #4766 on behalf of @mhevery to branch presubmit-mhevery-pr-4766.

@mhevery mhevery closed this in d896e43 Oct 15, 2015
@mhevery
mhevery deleted the upgrade branch June 2, 2017 17:09
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants