Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
"... and set the pure parameter to fase"
Contributor
|
Left a rewording proposal + backticks for code formatting! Otherwise LGTM! |
The documentation was outdated since alpha 38 when the `pure` parameter was added to the `PipeMetadata`.
Contributor
Author
|
Thanks, updated |
Contributor
|
👍 |
Contributor
Author
There was a problem hiding this comment.
Feel free to make one that I'll link here :)
Contributor
Author
|
The failed test has nothing to do with my update, could someone maybe relaunch it? |
vicb
added
pr_state: LGTM
action: merge
|
Merging PR #4667 on behalf of @vicb to branch presubmit-vicb-pr-4667. |
mary-poppins
removed
the
action: merge
vicb
pushed a commit
to vicb/angular
that referenced
this pull request
Oct 27, 2015
closes angular#4667 The documentation was outdated since alpha 38 when the `pure` parameter was added to the `PipeMetadata`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation was outdated since alpha 38 when the
pureparameter was added to thePipeMetadata.