Skip to content

feat(Binding): improve errors - #4360

Closed
vicb wants to merge 1 commit into
angular:masterfrom
vicb:0924-bindCheck
Closed

vicb wants to merge 1 commit into
angular:masterfrom
vicb:0924-bindCheck

Conversation

@vicb

@vicb vicb commented Sep 25, 2015

Copy link
Copy Markdown
Contributor

fix #4358

@vicb vicb added comp: core/di action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 25, 2015
@pkozlowski-opensource

Copy link
Copy Markdown
Member

@vicb what do you think about adding "positive" cases as well? It probably doesn't belong here but currently https://github.com/angular/angular/blob/master/modules/angular2/src/core/facade/lang.ts doesn't have proper tests for isFunction / isClass.

Unless we assume that those utils are sufficiently tested by all the other tests in the ng2 codebase.

@pkozlowski-opensource

Copy link
Copy Markdown
Member

LGTM otherwise, feel free to merge if you think that more tests wouldn't add much here.

@pkozlowski-opensource

Copy link
Copy Markdown
Member

Oh, and BTW, I guess this check makes sense only for people using ES5/ES6, right? Since both Dart and TS should catch this, no? So I guess we should have some policy on those checks?

@pkozlowski-opensource pkozlowski-opensource added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 25, 2015
@mary-poppins

Copy link
Copy Markdown

Merging PR #4360 on behalf of @vicb to branch presubmit-vicb-pr-4360.

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Sep 25, 2015
@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 25, 2015
@vicb

vicb commented Sep 25, 2015

Copy link
Copy Markdown
Contributor Author

@pkozlowski-opensource yep the check only makes sense for ES5 & ES6

@vicb vicb closed this in 0319417 Sep 25, 2015
@vicb
vicb deleted the 0924-bindCheck branch September 29, 2015 23:37
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error when incorrectly binding toClass

4 participants