Skip to content

fix(benchpress): fix benchpress over-reporting in chrome45 - #4101

Closed
goderbauer wants to merge 1 commit into
angular:masterfrom
goderbauer:benchpress-chrome-45
Closed

fix(benchpress): fix benchpress over-reporting in chrome45#4101
goderbauer wants to merge 1 commit into
angular:masterfrom
goderbauer:benchpress-chrome-45

Conversation

@goderbauer

@goderbauer goderbauer commented Sep 9, 2015

Copy link
Copy Markdown
Contributor

closes #4011

@goderbauer goderbauer assigned goderbauer and tbosch and unassigned goderbauer Sep 9, 2015
tbosch
tbosch reviewed Sep 9, 2015
View reviewed changes
Comment thread modules/benchpress/src/webdriver/chrome_driver_extension.ts

@tbosch tbosch Sep 9, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael, could you check whether this strange Function reports are nested inside of other Function calls? If so, I would prefer checking for this nesting instead of for the scriptName

@tbosch tbosch Sep 9, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline, these function calls are not nested...

@goderbauer goderbauer Sep 9, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are nested by looking at the raw events in #4101

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 9, 2015
@tbosch

tbosch commented Sep 9, 2015

Copy link
Copy Markdown
Contributor

Please add a test

@goderbauer

goderbauer commented Sep 9, 2015

Copy link
Copy Markdown
Contributor Author

Test added.

@tbosch tbosch added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 9, 2015
@mary-poppins

mary-poppins commented Sep 9, 2015

Copy link
Copy Markdown

Merging PR #4101 on behalf of @tbosch to branch presubmit-tbosch-pr-4101.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 9, 2015
@goderbauer goderbauer closed this in 0653b82 Sep 9, 2015
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@tbosch tbosch

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Benchpress is over-reporting in Chrome 45

5 participants

@goderbauer @tbosch @mary-poppins @mhevery @googlebot