Skip to content

fix(http): change http interfaces to types #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffbcross wants to merge 1 commit into from
Closed

fix(http): change http interfaces to types #4024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions modules/angular2/src/http/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ export class Connection {
* Interface for options to construct a Request, based on
* [RequestInit](https://fetch.spec.whatwg.org/#requestinit) from the Fetch spec.
*/
// TODO(jeffbcross): Change to type declaration when #3828 is fixed
// https://github.com/angular/angular/issues/3828
export interface RequestOptionsArgs {
export type RequestOptionsArgs = {
url?: string;
method?: RequestMethods;
search?: string | URLSearchParams;
Expand All @@ -48,7 +46,7 @@ export interface RequestOptionsArgs {
* Interface for options to construct a Response, based on
* [ResponseInit](https://fetch.spec.whatwg.org/#responseinit) from the Fetch spec.
*/
export interface ResponseOptionsArgs {
export type ResponseOptionsArgs = {
// TODO: Support Blob, ArrayBuffer, JSON
body?: string | Object | FormData;
status?: number;
Expand Down