Repository navigation
Conversation
There was a problem hiding this comment.
change to a getView() to match the rest. move closer to other getters.
3252424 to
1ee10d2
Compare
There was a problem hiding this comment.
I thought descendants is supposed to be set to true for ViewQuery
There was a problem hiding this comment.
Good catch, it's usage is already removed from the logic. This is just needed because ViewQueryMetadata extends QueryMetadata (probably they should just extend an abstract base). Changed this to avoid confusion.
Instead of working with finer grained element injectors, queries now iterate through the views as static units of modification of the application structure. Views already contain element injectors in the correct depth-first preorder. This allows us to remove children linked lists on element injectors and a lot of book keeping that is already present at the view level. Queries are recalculated using the afterContentChecked and afterViewChecked hooks, only during init and after a view container has changed. BREAKING CHANGE: ViewQuery no longer supports the descendants flag. It queries the whole component view by default.
1ee10d2 to
7c62c7c
Compare
|
Merging PR #3973 on behalf of @rkirov to branch presubmit-rkirov-pr-3973. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Instead of working with finer grained element injectors, queries now
iterate through the views as static units of modification of the
application structure. Views already contain element injectors in the
correct depth-first preorder.
This allows us to remove children linked lists on element injectors and a
lot of book keeping that is already present at the view level.
Queries are recalculated using the afterContentChecked and
afterViewChecked hooks, only during init and after a view container has
changed.
BREAKING CHANGE:
ViewQuery no longer supports the descendants flag. It queries the whole
component view by default.