Repository navigation
fix: source-maps - consistent paths to inline content - #39302
petebacondarwin wants to merge 3 commits into
Conversation
|
Hmm, CI points out that this does not really work well... I think we need a better solution... |
bb7e6aa to
9b96bad
Compare
The describe block was closed too early.
… content Previously, if a source-map contained inline content, the internal path used for the source file could be inconsistent depending upon the location of the source-map file that is referencing the source. Now inline source is assigned a consistent file path, rather than relying upon the path provided in the source-map. Since the source content is provided inline this should have no impact on the use of the flattened source-map by tools. Fixes angular#39293
9b96bad to
22c4e1c
Compare
|
I've realised that we cannot fix things this way. By hacking the source path for inline files we end up losing the path to the original source in a way that would break i18n extraction. See the integration test results from this PR: (Note that the path we would really like is |
|
I'm not sure if we can actually fix the problem from this side. We may need to return to the original cause #14021 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Previously, if a source-map contained inline content, the internal path used for
the source file could be inconsistent depending upon the location of the source-map
file that is referencing the source.
Now inline source is assigned a consistent file path, rather than relying upon the
path provided in the source-map. Since the source content is provided inline
this should have no impact on the use of the flattened source-map by tools.
Fixes #39293