ci: update components repo unit tests job commit - #37176
Closed
devversion wants to merge 2 commits into
Closed
devversion wants to merge 2 commits into
devversion wants to merge 2 commits into
Conversation
devversion
added
area: build & ci
devversion
marked this pull request as ready for review
May 18, 2020 09:28
josephperrott
removed
the
action: review
kara
added
action: merge
Contributor
|
Note: doesn't apply cleanly to patch. @devversion Can you create another PR for that? |
Member
Author
devversion
added
the
action: cleanup
Updates the commit the `components-repo-unit-tests` job runs against. The goal is that we run against a revision that at least contains: angular/components#19336. The new commit contains fixes for a flaky test in the datepicker that we saw failing in the components-repo-unit-tests job too: https://app.circleci.com/pipelines/github/angular/angular/15359/workflows/27ffae7c-a7b8-46a3-9c9e-6dd22ca4734d/jobs/712643. Additionally, with this commit, the components repo unit tests job will use TypeScript 3.9.2, so we can re-enable the job in another commit.
With 844208f, we disabled the components-repo-unit-tests job. The components repo landed the required TS 3.9.x update, so we can re-enable the job again.
devversion
force-pushed
the
ci/update-comp-repo-job-flaky-test
branch
from
May 18, 2020 18:15
45aa494 to
c1c2034
Compare
Member
Author
|
I wanted to send another PR for updating to the components-repo commit for the TS 3.9 update, but changes were so similar, I incorporated that into this PR. Also this now re-enables the job. |
devversion
removed
the
action: cleanup
kara
pushed a commit
that referenced
this pull request
May 18, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
Updates the commit the `components-repo-unit-tests` job runs against. The goal is that we run against a revision that at least contains: angular/components#19336. The new commit contains fixes for a flaky test in the datepicker that we saw failing in the components-repo-unit-tests job too: https://app.circleci.com/pipelines/github/angular/angular/15359/workflows/27ffae7c-a7b8-46a3-9c9e-6dd22ca4734d/jobs/712643. Additionally, with this commit, the components repo unit tests job will use TypeScript 3.9.2, so we can re-enable the job in another commit. PR Close angular#37176
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
With 844208f, we disabled the components-repo-unit-tests job. The components repo landed the required TS 3.9.x update, so we can re-enable the job again. PR Close angular#37176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.