fix(dev-infra): misc fixes for the compare master and patch script by AndrewKushnir · Pull Request #37150 · angular/angular

AndrewKushnir · 2020-05-16T00:25:47Z

This commit includes a couple minor fixes for the script that compares master and patch branch:

take only relevant release commit into account while generating the diff
fix the initial version display (avoid '+' sign from being added)
removes obsolete parameter that was needed for v9.0.x branch only

PR Type

What kind of change does this PR introduce?

Bugfix

Does this PR introduce a breaking change?

Yes
No

This commit includes a couple minor fixes for the script that compares master and patch branch: - take only relevant release commit into account while generating the diff - fix the initial version display (avoid '+' sign from being added) - removes obsolete parameter that was needed for v9.0.x branch only

IgorMinar · 2020-05-16T00:35:29Z

The new output looks good to me!


Comparing branches "9.1.x" and master.

***** Only in MASTER *****
[initial] 00efacf561 feat(service-worker): support timeout in `registerWhenStable` SW registration strategy (#35870)
[initial] 29e8a64cf0 fix(service-worker): by default register the SW after 30s even the app never stabilizes (#35870)
[initial] 2d7c95fb70 fix(service-worker): prevent SW registration strategies from affecting app stabilization (#35870)
[initial] bc089abd32 docs: add strictTemplates in place of fullTemplateTypeCheck (#35628)
[initial] 36e927a8c6 fix(zone.js): UNPATCHED_EVENTS and PASSIVE_EVENTS should be string[] not boolean (#36258)
[initial] 568e9df1d6 fix(router): allow UrlMatcher to return null (#36402)
[initial] 4374931b0e fix(zone.js): zone.js patch jest should handle done correctly (#36022)
[v10.0.0-next.0+] 4cf89d4bd7 docs: replace `browserslist` with `.browserslistrc` (#36504)
[v10.0.0-next.1+] d50cb30443 test: disable failing saucelabs tests (#36620)
[v10.0.0-next.2+] bfda7ca5bd docs(changelog): Add new line between changes (#36653)
[v10.0.0-next.2+] 5e79799b89 chore: update saucelabs README with some more details on local testing (#36625)
[v10.0.0-next.2+] 39b043646b docs: add example to illustrate binding order differences in ivy (#36643)
[v10.0.0-next.3+] 00e6cb1d62 feat(router): allow CanLoad guard to return UrlTree (#36610)
[v10.0.0-next.3+] 4172707346 refactor(compiler): tighten type of `TemplateParser._console` (#36741)
[v10.0.0-next.3+] e0aa39929b refactor(compiler): simplify tokenizer and parser results (#36741)
[v10.0.0-next.3+] aa0dd0d5ff test(compiler): fix unwanted `!` operators (#36741)
[v10.0.0-next.3+] 7bc5bcde34 test(compiler): check extracted translations for line endings (#36741)
[v10.0.0-next.3+] 70dd27ffd8 fix(compiler): normalize line endings in ICU expansions (#36741)
[v10.0.0-next.3+] a6a7e1bb99 build: enable platform-browser tests on Saucelabs (#36797)
[v10.0.0-next.4+] 49be32c931 refactor(common): remove WrappedValue from AsyncPipe (#36633)
[v10.0.0-next.4+] dc9f4b994e feat(service-worker): include `CacheQueryOptions` options in ngsw-config (#34663)
[v10.0.0-next.4+] ee35e223a7 feat(service-worker): use `ignoreVary: true` when retrieving responses from cache (#34663)
[v10.0.0-next.4+] bf0c520f2e refactor(localize): simplify adding condition diagnostics (#36792)
[v10.0.0-next.4+] 3cb9b43851 refactor(localize): hide merging diagnostics messages behind a method (#36792)
[v10.0.0-next.4+] 72f534f7f8 feat(localize): support merging multiple translation files (#36792)
[v10.0.0-next.4+] ee435761fd refactor(ngcc): improve locker pausing message (#36838)
[v10.0.0-next.4+] d805526659 fix(ngcc): provide a unique exit code for timeouts (#36838)
[v10.0.0-next.4+] 9b85b533ff test(ngcc): remove duplicate test (#36838)
[v10.0.0-next.4+] 98931bf9b5 refactor(ngcc): rename `Configuration.getConfig()` (#36838)
[v10.0.0-next.4+] 38f805cd06 feat(ngcc): allow async locking timeouts to be configured (#36838)
[v10.0.0-next.4+] 95a407d9dd build: Add entry point for Ivy language service (#36864)
[v10.0.0-next.4+] d9c4840a9c fix(router): cancel navigation when at least one resolver completes with no "next" emission (#24621)
[v10.0.0-next.4+] 9d9d46f52b fix(core): log error instead of warning for unknown properties and elements (#36399)
[v10.0.0-next.4+] 58ea040570 test(language-service): add new mock host for testing ivy (#36879)
[v10.0.0-next.5+] 88a235de3a fix(forms): handle numeric values properly in the validator (#36157)
[v10.0.0-next.5+] 2200c8a87b docs: Add new section, tutorials, to left nav, and a tutorial on routing (#36545)
[v10.0.0-next.5+] 63455b839a docs: list IE 9 and 10 as deprecated (#36887)
[v10.0.0-next.5+] 0fc6ed3c4a docs: update likely deprecation version in deprecation guide (#36891)
[v10.0.0-next.5+] 2de34770c4 docs: update deprecation guide to move deprecated APIs to removals (#36891)
[v10.0.0-next.5+] dbd0f8e699 feat(language-service): [ivy] Parse Angular compiler options (#36922)
[v10.0.0-next.5+] 420c179b39 build: update dependencies to use typescript 3.8 and angular 9.1 (#36329)
[v10.0.0-next.5+] fbd281c26e build: remove typescript 3.6 and 3.7 support (#36329)
[v10.0.0-next.5+] 388dc93cee feat: remove @angular/http (#27038)
[v10.0.0-next.5+] da79e0433f test(language-service): [ivy] Add mock service to overwrite files (#36923)
[v10.0.0-next.5+] bab90a7709 fix(compiler-cli): fix bug tracking indirect NgModule dependencies (#36211)
[v10.0.0-next.5+] 4213e8d5f0 fix(compiler): switch to 'referencedFiles' for shim generation (#36211)
[v10.0.0-next.5+] b861e9c0ac perf(compiler-cli): split Ivy template type-checking into multiple files (#36211)
[v10.0.0-next.5+] ecffc3557f perf(compiler-cli): perform template type-checking incrementally (#36211)
[v10.0.0-next.5+] c9e0db55f7 refactor(core): deprecate `WrappedValue` (#36819)
[v10.0.0-next.5+] 9dbb30f884 feat(bazel): simplify ng_package by dropping esm5 and fesm5 (#36944)
[v10.0.0-next.5+] d578ab8f3c build: simplify package.jsons for all of our packages (#36944)
[v10.0.0-next.5+] d5293d2aa3 fix(bazel): ng_package rule should update "package.json" of ts_library targets (#36944)
[v10.0.0-next.5+] c98a4d6ddd feat(ngcc): support for new APF where `module` points to esm2015 output (#36944)
[v10.0.0-next.5+] 040253c426 build: update side-effects integration test to not expect esm5 output (#36944)
[v10.0.0-next.5+] 9bde1be5a4 test: disable ng_package tests in ivy test jobs (#36944)
[v10.0.0-next.5+] 6fa36e387f test(docs-infra): temporarily disable the 'upgrade-phonecat-2-hybrid' docs example test (#36944)
[v10.0.0-next.7+] b2a3325258 docs: remove the note about @angular/http from the deprecations guide (#37070)
[v10.0.0-next.5+] 420b9be1c1 refactor: disable sanitization for [style] and [style.prop] bindings (#35621)
[v10.0.0-next.5+] 20cc3ab37e refactor(core): make generic mandatory for ModuleWithProviders (#36892)
[v10.0.0-next.5+] c6ecdc9a81 feat(core): undecorated-classes-with-decorated-fields migration should handle classes with lifecycle hooks (#36921)
[v10.0.0-next.5+] 4c92cf43cf feat(compiler-cli): report error if undecorated class with Angular features is discovered (#36921)
[v10.0.0-next.5+] 0577bf0e3e refactor: enable ng update migrations for v10 (#36921)
[v10.0.0-next.5+] e17fe90aaa refactor: fix undecorated classes with angular features in repo (#36921)
[v10.0.0-next.5+] 854bd7d0c8 build(docs-infra): do not require abstract directives to declare a @ngModule (#36921)
[v10.0.0-next.5+] f930e75a80 ci: update components-repo-unit-tests job commit (#36921)
[v10.0.0-next.5+] 97d6d909e7 fix(forms): number input fires valueChanges twice. (#36087)
[v10.0.0-next.5+] d0280a0335 fix(compiler): remove outdated and invalid warning for unresolved DI parameters (#36985)
[v10.0.0-next.5+] 42d1091d6a fix(compiler-cli): don't try to tag non-ts files as shims (#36987)
[v10.0.0-next.6+] 178e750f16 docs: Fix typo in navigation.json (#36955)
[v10.0.0-next.6+] eca2246fbc docs: add FireFox ESR to the supported list (#36973)
[v10.0.0-next.6+] 5f3fba43fa ci: update tested browsers to match supported browsers (#36973)
[v10.0.0-next.6+] 82a3bd5e8b ci: disable sauce labs safari and ios tests (#36973)
[v10.0.0-next.6+] 1142c378fd feat(language-service): [ivy] wrap ngtsc to handle typecheck files (#36930)
[v10.0.0-next.6+] 8d8e419664 fix(core): correct "development mode" console message (#36571)
[v10.0.0-next.7+] 141fcb95a4 refactor(localize): use the `FileSystem` from ngtsc (#36843)
[v10.0.0-next.7+] 45f4a47286 refactor(core): remove style sanitization code for `[style]`/`[style.prop]` bindings (#36965)
[v10.0.0-next.7+] 9edea0bb75 feat(platform-server): use absolute URLs from Location for HTTP (#37071)
[v10.0.0-next.7+] 57a868627f test(docs-infra): re-enable upgrade-phonecat-2-hybrid example e2e tests (#36969)
[v10.0.0-next.7+] c42f35eb2f build: pin @microsoft/api-extractor to 7.7.11 (#36989)
[v10.0.0-next.7+] a32cbed89c fix(language-service): use empty statement as parent of type node (#36989)
[v10.0.0-next.7+] b58bd2bb91 test(language-service): external template update should not invalidate program (#36989)
[v10.0.0-next.7+] 13ba84731f build: prepare for TypeScript 3.9 (#36989)
[v10.0.0-next.7+] 491da99abe refactor(ngcc): simplify the `detectKnownDeclaration()` signature (#36989)
[v10.0.0-next.7+] 0066a1ae70 refactor(compiler-cli): simplify and clarify `TypeScriptReflectionHost.isClass()` (#36989)
[v10.0.0-next.7+] dbcaf22805 refactor(compiler-cli): delegate `hasBaseClass()` to `getBaseClassExpression()` (#36989)
[v10.0.0-next.7+] 7ebf35c5f8 refactor(ngcc): remove unused import (#36989)
[v10.0.0-next.7+] a2b8dc1cfb refactor(ngcc): ensure unlocker process works in mock file-systems (#36989)
[v10.0.0-next.7+] d7440c452a fix(ngcc): ensure reflection hosts can handle TS 3.9 IIFE wrapped classes (#36989)
[v10.0.0-next.7+] c8ee390d23 fix(ngcc): ensure rendering formatters work with IIFE wrapped classes (#36989)
[v10.0.0-next.7+] 2956f21d82 test(ngcc): move specs to correct describe block (#36989)
[v10.0.0-next.7+] 8b79075497 test(compiler-cli): hande TS 3.9 format in emisson tests (#36989)
[v10.0.0-next.7+] 9846b19986 test(ngcc): reformat some subject code for tests (#36989)
[v10.0.0-next.7+] 0672a0e547 refactor(ngcc): rename `ReexportStatement` to `WildcardReexportStatement` (#36989)
[v10.0.0-next.7+] 2486db7c2b docs(ngcc): tidy up typos etc in comments (#36989)
[v10.0.0-next.7+] d268d2ad85 fix(ngcc): `viaModule` should be `null` for local imports (#36989)
[v10.0.0-next.7+] 91092f668e fix(ngcc): support `defineProperty()` re-exports in CommonJS and UMD (#36989)
[v10.0.0-next.7+] b0e362f75b test(docs-infra): update payload sizes after TS 3.9 update (#36989)
[v10.0.0-next.7+] 4e1b5e43fa fix(compiler-cli): compute the correct target output for `$localize` messages (#36989)
[v10.0.0-next.7+] 466df41c8f test: update payload sizes after TS 3.9 update (#36989)
[v10.0.0-next.7+] bbd556ee9f test: enable importHelpers for UMD builds (#36989)
[v10.0.0-next.7+] 24ec5235a0 test: disable `cli-hello-world-lazy-rollup` from ivy tests (#36989)
[v10.0.0-next.7+] f97d8a9cbd refactor: `EventEmitter` to retain behaviour of pre TypeScript 3.9 (#36989)
[v10.0.0-next.7+] 508c555ce2 test: update language service module resolution cache (#36989)
[v10.0.0-next.7+] f16ca1ce46 build(docs-infra): correctly handle "pseudo" classes (#36989)
[v10.0.0-next.7+] 8a56c99f87 docs(router): Update router guide to use UrlTree for guard redirects (#37100)
[v10.0.0-next.7+] 42a9e5ad7d ci: increase payload size limits for integration tests (#37123)
[v10.0.0-next.7+] 55c2433171 docs(changelog): remove duplicate features and bug fixes (#37101)
[v10.0.0-next.7+] 7f58c579f3 docs(changelog): add breaking change note for ModuleWithProviders (#37121)

***** Only in PATCH (9.1.x) *****
[v9.1.2+] 8bd5374cfd revert: fix(common): format day-periods that cross midnight (#36611) (#36751)
[v9.1.3+] 62930aac7b Revert "refactor(localize): move `source_file_utils.ts` up (#36834)" (#36861)
[v9.1.5+] be06a44861 Revert "test(compiler-cli): ensure reflection tests are not brittle to case-sensitivity (#36968)" (#37003)
[v9.1.5+] 04fd90e32a Revert "test(compiler-cli): ensure partial-evaluator tests are not brittle to case-sensitivity (#36968)" (#37003)
[v9.1.5+] bf446cb2d5 Revert "test(compiler-cli): ensure indexer tests are not brittle to case-sensitivity (#36968)" (#37003)
[v9.1.5+] 6cce05e2c5 Revert "fix(compiler-cli): use CompilerHost to ensure canonical file paths (#36968)" (#37003)
[v9.1.5+] 0783d482a7 Revert "fix(compiler-cli): normalize mock Windows file paths correctly (#36968)" (#37003)
[v9.1.5+] 00cc02fb0c Revert "fix(compiler-cli): ensure `MockFileSystem` handles case-sensitivity (#36968)" (#37003)
[v9.1.5+] 0fc0d9bb3d Revert "fix(compiler-cli): `isCaseSensitive()` returns correct value (#36968)" (#37003)
[v9.1.5+] 4423ab5109 Revert "fix(compiler-cli): ensure `getRootDirs()` handles case-sensitivity (#36968)" (#37003)
[v9.1.5+] 00b9de56f5 Revert "fix(compiler-cli): ensure LogicalFileSystem handles case-sensitivity (#36968)" (#37003)
[v9.1.5+] 99b63b677e Revert "fix(compiler-cli): fix case-sensitivity issues in NgtscCompilerHost (#36968)" (#37003)
[v9.1.6+] d808333047 ci: increase AIO payload size limit (#37124)

***** Features in PATCH (9.1.x) - should always be empty *****
No extra commits

IgorMinar

lgtm after you resolve the comment about dropping the release notes commit.

AndrewKushnir · 2020-05-16T00:41:01Z

Thanks for the review @IgorMinar 👍

…37150) This commit includes a couple minor fixes for the script that compares master and patch branch: - take only relevant release commit into account while generating the diff - fix the initial version display (avoid '+' sign from being added) - removes obsolete parameter that was needed for v9.0.x branch only PR Close #37150

angular-automatic-lock-bot · 2020-06-18T16:10:49Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…ngular#37150) This commit includes a couple minor fixes for the script that compares master and patch branch: - take only relevant release commit into account while generating the diff - fix the initial version display (avoid '+' sign from being added) - removes obsolete parameter that was needed for v9.0.x branch only PR Close angular#37150

AndrewKushnir added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels May 16, 2020

AndrewKushnir requested a review from IgorMinar May 16, 2020 00:25

ngbot Bot modified the milestone: needsTriage May 16, 2020

googlebot added the cla: yes label May 16, 2020

IgorMinar reviewed May 16, 2020

View reviewed changes

Comment thread scripts/compare-master-to-patch.js

IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 16, 2020

IgorMinar approved these changes May 16, 2020

View reviewed changes

IgorMinar removed the action: review The PR is still awaiting reviews from at least one requested reviewer label May 16, 2020

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 16, 2020

kara closed this in 8004eb0 May 18, 2020

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 18, 2020

Navigation Menu

fix(dev-infra): misc fixes for the compare master and patch script - #37150

fix(dev-infra): misc fixes for the compare master and patch script#37150
AndrewKushnir wants to merge 1 commit into
angular:masterfrom
AndrewKushnir:compare_branches_script_updates

AndrewKushnir commented May 16, 2020

Uh oh!

Uh oh!

IgorMinar commented May 16, 2020

Uh oh!

IgorMinar left a comment

Uh oh!

AndrewKushnir commented May 16, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Jun 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

AndrewKushnir commented May 16, 2020

PR Type

Does this PR introduce a breaking change?

Uh oh!

Uh oh!

IgorMinar commented May 16, 2020

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented May 16, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Jun 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants