Repository navigation
ngcc: move logging and sourcemaps - #37114
Closed
petebacondarwin wants to merge 3 commits into
Closed
petebacondarwin wants to merge 3 commits into
petebacondarwin wants to merge 3 commits into
Conversation
petebacondarwin
added
action: review
alxhub
approved these changes
May 15, 2020
Member
Contributor
Author
|
@IgorMinar this is another refactoring that will be used by the |
petebacondarwin
force-pushed
the
ngcc-move-logging-and-sourcemaps
branch
3 times, most recently
from
May 19, 2020 18:21
d851165 to
4c0623d
Compare
petebacondarwin
force-pushed
the
ngcc-move-logging-and-sourcemaps
branch
2 times, most recently
from
June 1, 2020 08:58
7b9b6b4 to
8be5b56
Compare
devversion
approved these changes
Jun 2, 2020
petebacondarwin
added
action: presubmit
petebacondarwin
force-pushed
the
ngcc-move-logging-and-sourcemaps
branch
4 times, most recently
from
June 10, 2020 14:40
77fca0f to
024e8cc
Compare
Member
|
Caretaker: cl/315733339 is a prereq for this PR. It patches the sync process to not sync |
petebacondarwin
force-pushed
the
ngcc-move-logging-and-sourcemaps
branch
2 times, most recently
from
June 13, 2020 17:11
01e7a52 to
aca9274
Compare
petebacondarwin
added
action: merge
Contributor
petebacondarwin
force-pushed
the
ngcc-move-logging-and-sourcemaps
branch
6 times, most recently
from
June 20, 2020 09:26
3ddd430 to
fbbd41a
Compare
The `Logger` interface and its related classes are general purpose and could be used by other tooling. Moving it into ngtsc is a more suitable place from which to share it - similar to the FileSystem stuff.
The `SourceFile` and associated code is general and reusable in other projects (such as `@angular/localize`). Moving it to `ngtsc` makes it more easily shared.
* Re-order the `load` and `package` statements * Make `srcs` glob more generic * Remove unnecessary dependencies
petebacondarwin
force-pushed
the
ngcc-move-logging-and-sourcemaps
branch
from
June 22, 2020 18:53
fbbd41a to
7ee8b2f
Compare
mhevery
pushed a commit
that referenced
this pull request
Jun 22, 2020
The `SourceFile` and associated code is general and reusable in other projects (such as `@angular/localize`). Moving it to `ngtsc` makes it more easily shared. PR Close #37114
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
The `Logger` interface and its related classes are general purpose and could be used by other tooling. Moving it into ngtsc is a more suitable place from which to share it - similar to the FileSystem stuff. PR Close angular#37114
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
The `SourceFile` and associated code is general and reusable in other projects (such as `@angular/localize`). Moving it to `ngtsc` makes it more easily shared. PR Close angular#37114
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
…ngular#37114) * Re-order the `load` and `package` statements * Make `srcs` glob more generic * Remove unnecessary dependencies PR Close angular#37114
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
The `Logger` interface and its related classes are general purpose and could be used by other tooling. Moving it into ngtsc is a more suitable place from which to share it - similar to the FileSystem stuff. PR Close angular#37114
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
The `SourceFile` and associated code is general and reusable in other projects (such as `@angular/localize`). Moving it to `ngtsc` makes it more easily shared. PR Close angular#37114
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ngular#37114) * Re-order the `load` and `package` statements * Make `srcs` glob more generic * Remove unnecessary dependencies PR Close angular#37114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring is another precursor to i18n message extraction in
@angular/localize.