Cherry-picking commits from master to patch (9.0.x) - #34960
AndrewKushnir wants to merge 3 commits into
Conversation
`String.fromCharCode`'s type signature requires a regular `number[]`. PR Close angular#34817
Previously, create_angular_testing_module would export a mutable `let` binding. The binding is already exporting using an accessor function though, so the export on the let variable seems like an accidental oversight. This is functionally equivalent, but makes it easier for module optimizers such as Closure Compiler to track down side effects and prune modules. PR Close angular#34232
Previously, browser_util would export a mutable `let` binding that was initialized as a side-effect of `BrowserDetection.setup()`. This change refactors the mutable binding into a `const` binding that is immediately initialized in its initialized. This is functionally equivalent, but makes it easier for module optimizers such as Closure Compiler to track down side effects and prune modules. It is also arguably cleaner to read (no worries about later changes to the apparently mutable but effectively const binding). PR Close angular#34207
AndrewKushnir
added
action: review
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
AndrewKushnir
added
action: merge
Previously, create_angular_testing_module would export a mutable `let` binding. The binding is already exporting using an accessor function though, so the export on the let variable seems like an accidental oversight. This is functionally equivalent, but makes it easier for module optimizers such as Closure Compiler to track down side effects and prune modules. PR Close #34232 PR Close #34960
Previously, browser_util would export a mutable `let` binding that was initialized as a side-effect of `BrowserDetection.setup()`. This change refactors the mutable binding into a `const` binding that is immediately initialized in its initialized. This is functionally equivalent, but makes it easier for module optimizers such as Closure Compiler to track down side effects and prune modules. It is also arguably cleaner to read (no worries about later changes to the apparently mutable but effectively const binding). PR Close #34207 PR Close #34960
|
This PR is now merged to patch branch (9.0.x). |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
This PR contains a set of commits that landed in master only, but should've been merged into patch branch as well.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?