Skip to content

build: remove @angular/http from modules - #34892

Closed
CaerusKaru wants to merge 1 commit into
angular:masterfrom
CaerusKaru:adam/http-etc
Closed

build: remove @angular/http from modules#34892
CaerusKaru wants to merge 1 commit into
angular:masterfrom
CaerusKaru:adam/http-etc

Conversation

@CaerusKaru

@CaerusKaru CaerusKaru commented Jan 22, 2020

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CaerusKaru
CaerusKaru requested a review from IgorMinar as a code owner January 22, 2020 02:53
@CaerusKaru CaerusKaru mentioned this pull request Jan 22, 2020
Closed
@CaerusKaru

CaerusKaru commented Jan 22, 2020

Copy link
Copy Markdown
Member Author

This is needed to complete #27038

IgorMinar
IgorMinar approved these changes Jan 22, 2020
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project comp: http action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 22, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Jan 22, 2020
AndrewKushnir pushed a commit that referenced this pull request Jan 22, 2020
@CaerusKaru @AndrewKushnir
build: remove @angular/http from modules (#34892)
e83fe87 
PR Close #34892
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Feb 22, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@CaerusKaru @IgorMinar @googlebot