refactor(http): fix a strictBindCallApply issue. - #34817

The HTTP package is no longer published or supported, and I'd hate to set a precedent that we're still updating it. If this is a blocker for strict support elsewhere, my vote is for finally deleting this package via #27038.

cc @IgorMinar

Thank you for requesting my review, @mprobst. I'd like to wait until engineering has had a chance to review and then come to check it from a docs perspective. Will you tag me once the engineering review process is done (in case I miss it)?

@CaerusKaru this PR fixes a trivial compilation issue with a (not that) new TS strictness flag. I understand that a more general cleanup is planned, but given this is a one line essentially, I don't think we should block on the more general cleanup (which I suspect is hard - we'd need to remove all users of the code, not just the code itself!).

@kapunahelewong ack, but I think there's no docs impact in this PR.

@mprobst HTTP hasn’t been updated since v7, and that won’t change. The users of HTTP (granted, only those outside g3) have already been dealt with. I very strongly believe we should just continue with the removal, especially since most of the work has been done to do so (in the PR linked above)

@CaerusKaru sure. What I'm fixing is that currently Angular does not compile with strictBindCallApply. I think that's orthogonal to whether or not to remove this code. Given that the timeline to remove the code as I understand it is not on the order of this week, I think it's worth landing this and then deleting the code later.

@mprobst I totally understand your point of view, which is why I’d like @IgorMinar to weigh in before we merge this. I don’t think the work is on the order of a week (unless you mean google3 work), but that’s just my opinion.

@mprobst ah yes, thank you! This was the first one that auto requested me. I'm catching on to the new notifications. Never mind! 🙃

@CaerusKaru this change is needed in g3 to compile the monorepo with this flag. External users/programs are not affected because they don't compile this package from sources.

In short, we should merge this and sync it to g3 but not release it on npm.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}