ci: Migrate from CODEOWNERS to PullApprove for PR review management by josephperrott · Pull Request #34814 · angular/angular

josephperrott · 2020-01-16T17:07:54Z

We are migrating to PullApprove for our PR review management in an attempt
to allow for more granular and equitable code review assignments across the
team. Currently this migration is equivalent in the review assignments
it will create. Once stable, our expectation is that we will be able to
take advantage of PullApprove's additional features for things like staged
reviews.

gkalpak · 2020-01-16T22:29:03Z

😞 Shouldn't we have a similar check for pullapprove?

Yes, The plan is to do this logic/check in a follow up PR.

Is there a tracking item in our backlog for this followup pr?

JoostK · 2020-01-23T23:41:46Z

I have gone missing from this list for some reason (I'm still in the compiler group below)

Sorry! I used the listing at aio/content/marketing/contributors.json to create the list and must have accidentally dropped you out of the list.

Does this include collaborators (noticed JiaLi in the list)? If so, I'm missing too!

The intention is for it to be a list that contains all of the usernames that are present as an owner for any of the groups defined in the file.

@IgorMinar @josephperrott Something I’ve been wondering for a while then, can we add the Googlers and Collaborators for Universal as members on platform-server? (That would be me, @alan-agius4, @kyliau, and @manfredsteyer)

googlebot · 2020-01-24T15:04:49Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

IgorMinar

Posting comments from my first pass... I also pushed a commit with some fixes I made locally.

Things we should not forget to update:

ng-bot config to require pullapprove status (.github/angular-robot.yml)
docs/COMMITTER.md which makes references to codeowners
docs/TRIAGE_AND_LABELS.md which also makes references to codeowners
what to do with existing gh groups? delete them?

IgorMinar · 2020-01-23T23:35:34Z

Is there a tracking item in our backlog for this followup pr?

IgorMinar · 2020-01-24T14:46:31Z

contains_any_globs is an odd name. shouldn't it be matches_any_globs?

also what is files in this context? the files modified by the PR?

matches_any_globs probably makes more sense, but is not the name of the method that they went with. I think it comes from a consistency in naming conventions with there other matcher methods.

Yes, all of the files modified in the PR.

IgorMinar · 2020-01-24T14:53:16Z

can you leave a comment explaining how this works? why active groups?

IgorMinar · 2020-01-24T15:05:55Z

@josephperrott can you please review my commit + rebase this? thanks

josephperrott

Created #34956 for the verify-codeownership followup.

googlebot · 2020-01-27T17:11:00Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2020-01-27T17:20:45Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews.

…ement

ngbot · 2020-01-28T04:38:51Z

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "cla/google" is failing
     status "ci/circleci: setup" is pending
     missing required status "ci/circleci: build"
     missing required status "ci/circleci: lint"
     missing required status "ci/circleci: publish_snapshot"
     missing required status "ci/angular: size"
     1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

googlebot · 2020-01-28T04:38:52Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

IgorMinar

I've rebased this and pushed a last set of fixup commits. I think this is good to go.

I'm marking this as "blocked" so that it is merged only once @josephperrott is around to babysit this PR and ensure that it doesn't break the world. 😄

…ement

googlebot · 2020-01-28T15:18:46Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

…ement

googlebot · 2020-01-28T15:56:08Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

…34814) We are migrating to PullApprove for our PR review management in an attempt to allow for more granular and equitable code review assignments across the team. Currently this migration is equivalent in the review assignments it will create. Once stable, our expectation is that we will be able to take advantage of PullApproves additional features for things like staged reviews. PR Close #34814

IgorMinar · 2020-01-28T17:23:10Z

live long and prosper pullaprove 🖖

This is a follow-up to angular#34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`.

This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015

angular-automatic-lock-bot · 2020-02-28T16:08:31Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

josephperrott added area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Jan 16, 2020

josephperrott requested a review from IgorMinar January 16, 2020 17:07

ngbot Bot added this to the needsTriage milestone Jan 16, 2020

googlebot added the cla: yes label Jan 16, 2020

josephperrott force-pushed the pullapprove branch from 7c7e2c5 to f614417 Compare January 16, 2020 17:27

josephperrott marked this pull request as ready for review January 16, 2020 18:00

josephperrott requested a review from a team January 16, 2020 18:00

CaerusKaru reviewed Jan 16, 2020

View reviewed changes

Comment thread .pullapprove.yml Outdated

gkalpak reviewed Jan 16, 2020

View reviewed changes

josephperrott force-pushed the pullapprove branch from fb64a4e to 644cb77 Compare January 16, 2020 23:03

CaerusKaru mentioned this pull request Jan 22, 2020

feat: remove @angular/http #27038

Closed

JoostK reviewed Jan 23, 2020

View reviewed changes

googlebot added cla: no and removed cla: yes labels Jan 24, 2020

IgorMinar suggested changes Jan 24, 2020

View reviewed changes

josephperrott commented Jan 24, 2020

View reviewed changes

josephperrott force-pushed the pullapprove branch 2 times, most recently from d767544 to 9e142e0 Compare January 24, 2020 20:16

IgorMinar added cla: yes and removed cla: no labels Jan 27, 2020

googlebot added cla: no and removed cla: yes labels Jan 27, 2020

josephperrott and others added 3 commits January 27, 2020 18:37

fixup! ci: Migrate from CODEOWNERS to PullApprove for PR review manag…

95de9f7

…ement

fixup! ci: Migrate from CODEOWNERS to PullApprove for PR review manag…

7220bad

…ement

IgorMinar added cla: yes action: merge The PR is ready for merge by the caretaker and removed cla: no labels Jan 28, 2020

IgorMinar added the state: blocked label Jan 28, 2020

IgorMinar approved these changes Jan 28, 2020

View reviewed changes

fixup! ci: Migrate from CODEOWNERS to PullApprove for PR review manag…

d2791e2

…ement

googlebot added cla: no and removed cla: yes labels Jan 28, 2020

fixup! ci: Migrate from CODEOWNERS to PullApprove for PR review manag…

d880aa4

…ement

josephperrott added cla: yes and removed state: blocked cla: no labels Jan 28, 2020

josephperrott closed this in 296dc06 Jan 28, 2020

gkalpak mentioned this pull request Jan 28, 2020

ci: minor PullApprove fixes/improvements #35015

Closed

gkalpak mentioned this pull request Jan 29, 2020

ci: Global approvers list in CODEOWNERS doesn't seem to work #28601

Closed

gkalpak added a commit to gkalpak/angular that referenced this pull request Jan 29, 2020

ci: minor PullApprove fixes/improvements

d690d54

This is a follow-up to angular#34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`.

AndrewKushnir pushed a commit that referenced this pull request Jan 29, 2020

ci: minor PullApprove fixes/improvements (#35015)

519e9e1

This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015

AndrewKushnir pushed a commit that referenced this pull request Jan 29, 2020

ci: minor PullApprove fixes/improvements (#35015)

4bc0abf

This is a follow-up to #34814 to fix some typos in patterns and make them more similar to the old patterns from `.github/CODEOWNERS`. PR Close #35015

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 28, 2020

Conversation

josephperrott commented Jan 16, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

googlebot commented Jan 24, 2020

Uh oh!

IgorMinar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IgorMinar commented Jan 24, 2020

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

googlebot commented Jan 27, 2020

Uh oh!

googlebot commented Jan 27, 2020

Uh oh!

ngbot Bot commented Jan 28, 2020

Uh oh!

googlebot commented Jan 28, 2020

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

googlebot commented Jan 28, 2020

Uh oh!

googlebot commented Jan 28, 2020

Uh oh!

IgorMinar commented Jan 28, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Feb 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

IgorMinar left a comment •

edited

Loading