Conversation
Previously, create_angular_testing_module would export a mutable `let` binding. The binding is already exporting using an accessor function though, so the export on the let variable seems like an accidental oversight. This is functionally equivalent, but makes it easier for module optimizers such as Closure Compiler to track down side effects and prune modules.
Contributor
Author
petebacondarwin
approved these changes
Dec 4, 2019
mprobst
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
AndrewKushnir
pushed a commit
to AndrewKushnir/angular
that referenced
this pull request
Jan 24, 2020
Previously, create_angular_testing_module would export a mutable `let` binding. The binding is already exporting using an accessor function though, so the export on the let variable seems like an accidental oversight. This is functionally equivalent, but makes it easier for module optimizers such as Closure Compiler to track down side effects and prune modules. PR Close angular#34232
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 24, 2020
Previously, create_angular_testing_module would export a mutable `let` binding. The binding is already exporting using an accessor function though, so the export on the let variable seems like an accidental oversight. This is functionally equivalent, but makes it easier for module optimizers such as Closure Compiler to track down side effects and prune modules. PR Close #34232 PR Close #34960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, create_angular_testing_module would export a mutable
letbinding. The binding is already exporting using an accessor function
though, so the export on the let variable seems like an accidental
oversight.
This is functionally equivalent, but makes it easier for module
optimizers such as Closure Compiler to track down side effects and prune
modules.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type