Repository navigation
Conversation
tbosch
added
the
action: review
Contributor
There was a problem hiding this comment.
add a check on the list of both to make sure they are equal to 1.
rkirov
added
pr_state: LGTM
and removed
action: review
Contributor
|
A few small changes, otherwise LGTM. In general I wonder if we need to expose some other pre-built objects? |
|
Merging PR #3202 on behalf of @tbosch to branch presubmit-tbosch-pr-3202. |
mary-poppins
removed
the
action: merge
|
Merging PR #3202 on behalf of @tbosch to branch presubmit-tbosch-pr-3202. |
mary-poppins
removed
the
action: merge
goderbauer
pushed a commit
to goderbauer/angular
that referenced
this pull request
Aug 15, 2015
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1989